llvm dev - Apr 2020 - [cfe-dev] State of NaCl in monorepo?

Hi all,

LLVM/Clang supports an OS called 'NaCl'
(llvm/include/llvm/ADT/Triple.h).
It apparently hasn't had any development since 2015.

This page https://developer.chrome.com/native-client/migration
mentions that NaCl is deprecated.

Is it still used? If not, I would propose that we remove it.
I created a patch https://reviews.llvm.org/D78441 which I think can
delete 90% of the related code.

There are still a few references left (noticeably aligned bundling in
MC)
https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/aligned-bundling-support-in-llvm
I will delete that as a follow-up.

My understanding is that the project is not active, if that is true, then there
doesn’t seem like a strong reason to keep support for it in ToT LLVM.

That said, please give this a week or two for people to object - I’d also
suggest poking some of the NaCl people at Google if you haven’t already,

-Chris
> On Apr 18, 2020, at 7:42 PM, Fangrui Song via cfe-dev <cfe-dev at
lists.llvm.org> wrote:
> 
> Hi all,
> 
> LLVM/Clang supports an OS called 'NaCl'
(llvm/include/llvm/ADT/Triple.h).
> It apparently hasn't had any development since 2015.
> 
> This page https://developer.chrome.com/native-client/migration
> mentions that NaCl is deprecated.
> 
> Is it still used? If not, I would propose that we remove it.
> I created a patch https://reviews.llvm.org/D78441 which I think can
> delete 90% of the related code.
> 
> There are still a few references left (noticeably aligned bundling in
> MC)
https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/aligned-bundling-support-in-llvm
> I will delete that as a follow-up.
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

On Sat, Apr 18, 2020 at 7:43 PM Fangrui Song via cfe-dev <
cfe-dev at lists.llvm.org> wrote:
> Hi all,
>
> LLVM/Clang supports an OS called 'NaCl'
(llvm/include/llvm/ADT/Triple.h).
> It apparently hasn't had any development since 2015.
>
> This page https://developer.chrome.com/native-client/migration
> mentions that NaCl is deprecated.
>
> Is it still used? If not, I would propose that we remove it.
> I created a patch https://reviews.llvm.org/D78441 which I think can
> delete 90% of the related code.
>
> There are still a few references left (noticeably aligned bundling in
> MC)
>
https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/aligned-bundling-support-in-llvm
> I will delete that as a follow-up.
>
AFAIK aligned bundling has other users (e.g. the author of
https://reviews.llvm.org/D19924 mentioned interested in using bundle locked
groups for Hexagon) so its removal should be probably treated as a separate
proposal.

> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200418/b5667f1f/attachment.html>

Hi Fangrui,
As you noted we are working on helping our NaCl users transition to
WebAssembly and new web APIs that cover the functionality offered by NaCl.
In terms of actually turning down the platform features, we recently
announced a timeline at
https://blog.chromium.org/2020/01/moving-forward-from-chrome-apps.html.

In terms of LLM, I would prefer to keep the support we have in the tree
until we complete the turndown as long as the support isn't unusually
onerous. Not all of our NaCl toolchain code is upstream, but we are
actually about to redo part of our current downstream code soon to improve
Chromium's C++ support until we complete the platform turndown. And of
course we continue to be available to support it upstream as needed,
especially if there is some particular problem you're looking to solve by
removing this code.
Feel free to contact me directly as well (aside from the usual channels
like this list of course) if you want more on NaCl or PNaCl.


On Sat, Apr 18, 2020 at 10:25 PM Petr Hosek via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Sat, Apr 18, 2020 at 7:43 PM Fangrui Song via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
>
>> Hi all,
>>
>> LLVM/Clang supports an OS called 'NaCl'
(llvm/include/llvm/ADT/Triple.h).
>> It apparently hasn't had any development since 2015.
>>
>> This page https://developer.chrome.com/native-client/migration
>> mentions that NaCl is deprecated.
>>
>> Is it still used? If not, I would propose that we remove it.
>> I created a patch https://reviews.llvm.org/D78441 which I think can
>> delete 90% of the related code.
>>
>> There are still a few references left (noticeably aligned bundling in
>> MC)
>>
https://sites.google.com/a/chromium.org/dev/nativeclient/pnacl/aligned-bundling-support-in-llvm
>> I will delete that as a follow-up.
>>
>
> AFAIK aligned bundling has other users (e.g. the author of
> https://reviews.llvm.org/D19924 mentioned interested in using bundle
> locked groups for Hexagon) so its removal should be probably treated as a
> separate proposal.
>
>
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200420/c683c926/attachment.html>