llvm dev - Dec 2019 - modification on lnt to recognize new architecture

Hi,

I have a question regarding to lnt.  We are working on NEC SX-Aurora Vector
Engine and
preparing for upstreaming it on https://reviews.llvm.org/D69103 and following
reviews.

We are running llvm-test-suite to check our modifications often.  To run this
test suite,
we need to specify our architecture to lnt and make program running under lnt to
handle
a few special cases.  In order to do so, we have very simple patch like below.

My question is where should I send this patch to make it merge with lnt
(https://github.com/llvm/llvm-lnt)?  I checked lists.llvm.org mailing lists,
but it is not clear to me.  Thanks in advance.

-----------
diff --git a/lnt/tests/nt.py b/lnt/tests/nt.py
index 4ce6647..ce37687 100644
--- a/lnt/tests/nt.py
+++ b/lnt/tests/nt.py
@@ -420,6 +420,8 @@ class TestConfiguration(object):
                 llvm_arch = 'Sparc'
             elif arch in ('mips', 'mipsel', 'mips64',
'mips64el'):
                 llvm_arch = 'Mips'
+            elif arch in ('ve'):
+                llvm_arch = 'VE'

         if llvm_arch is not None:
             make_variables['ARCH'] = llvm_arch
-----------

Regards,
-- Kazushi

Hi,
> On Dec 11, 2019, at 08:00, MARUKAWA KAZUSHI(丸川　一志) via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> 
> My question is where should I send this patch to make it merge with lnt
> (https://github.com/llvm/llvm-lnt)?  I checked lists.llvm.org mailing
lists,
> but it is not clear to me.  Thanks in advance.

I think you can follow the same process as for regular LLVM patches
(https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
<https://llvm.org/docs/Contributing.html#how-to-submit-a-patch>): either
via https://reviews.llvm.org <https://reviews.llvm.org/>  or the
llvm-commits list. At least that’s what I’ve done in the past.

In case you are not sure what reviewers to add, it might be worth taking a look
at recent LNT patches on llvm-commits, e.g. by looking for patches with [LNT] in
the subject.

Cheers
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191211/834c9ab9/attachment.html>

I am surprised that anyone is still using nt.py.  Have you tried using
test-suite.py instead?  That will allow you to pass custom cmake arguments
through to the test suite.
> On Dec 11, 2019, at 12:00 AM, MARUKAWA KAZUSHI(丸川　一志) via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> 
> Hi,
> 
> I have a question regarding to lnt.  We are working on NEC SX-Aurora Vector
Engine and
> preparing for upstreaming it on https://reviews.llvm.org/D69103 and
following reviews.
> 
> We are running llvm-test-suite to check our modifications often.  To run
this test suite,
> we need to specify our architecture to lnt and make program running under
lnt to handle
> a few special cases.  In order to do so, we have very simple patch like
below.
> 
> My question is where should I send this patch to make it merge with lnt
> (https://github.com/llvm/llvm-lnt)?  I checked lists.llvm.org mailing
lists,
> but it is not clear to me.  Thanks in advance.
> 
> -----------
> diff --git a/lnt/tests/nt.py b/lnt/tests/nt.py
> index 4ce6647..ce37687 100644
> --- a/lnt/tests/nt.py
> +++ b/lnt/tests/nt.py
> @@ -420,6 +420,8 @@ class TestConfiguration(object):
>                 llvm_arch = 'Sparc'
>             elif arch in ('mips', 'mipsel',
'mips64', 'mips64el'):
>                 llvm_arch = 'Mips'
> +            elif arch in ('ve'):
> +                llvm_arch = 'VE'
> 
>         if llvm_arch is not None:
>             make_variables['ARCH'] = llvm_arch
> -----------
> 
> Regards,
> -- Kazushi
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3637 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191211/04d44c61/attachment.bin>

Thank you very much, Florian.

I’ll follow those steps.

Regards,
-- Kazushi

From: florian_hahn at apple.com <florian_hahn at apple.com>
Sent: Wednesday, December 11, 2019 6:45 PM
To: MARUKAWA KAZUSHI(丸川　一志) <marukawa at nec.com>
Cc: llvm-dev at lists.llvm.org
Subject: Re: [llvm-dev] modification on lnt to recognize new architecture

Hi,


On Dec 11, 2019, at 08:00, MARUKAWA KAZUSHI(丸川　一志) via llvm-dev <llvm-dev at
lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:

My question is where should I send this patch to make it merge with lnt
(https://github.com/llvm/llvm-lnt)?  I checked
lists.llvm.org<http://lists.llvm.org> mailing lists,
but it is not clear to me.  Thanks in advance.


I think you can follow the same process as for regular LLVM patches
(https://llvm.org/docs/Contributing.html#how-to-submit-a-patch): either via
https://reviews.llvm.org  or the llvm-commits list. At least that’s what I’ve
done in the past.

In case you are not sure what reviewers to add, it might be worth taking a look
at recent LNT patches on llvm-commits, e.g. by looking for patches with [LNT] in
the subject.

Cheers
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191212/2b33fd4c/attachment-0001.html>

Thank you.  I'll try test_suite.py also.

Regards,
-- Kazushi
> -----Original Message-----
> From: chris.matthews at apple.com <chris.matthews at apple.com>
> Sent: Thursday, December 12, 2019 4:14 AM
> To: MARUKAWA KAZUSHI(丸川　一志) <marukawa at nec.com>
> Cc: llvm-dev at lists.llvm.org
> Subject: Re: [llvm-dev] modification on lnt to recognize new architecture
> 
> I am surprised that anyone is still using nt.py.  Have you tried using
test-suite.py instead?  That will allow you to
> pass custom cmake arguments through to the test suite.
> 
> > On Dec 11, 2019, at 12:00 AM, MARUKAWA KAZUSHI(丸川　一志) via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> >
> > Hi,
> >
> > I have a question regarding to lnt.  We are working on NEC SX-Aurora
Vector Engine and
> > preparing for upstreaming it on https://reviews.llvm.org/D69103 and
following reviews.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4583 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191212/e2e0c6bd/attachment.bin>