Tim Northover via llvm-dev
2016-Jul-23 23:01 UTC
[llvm-dev] FreeBSD user willing to try fix a unit test?
On 23 July 2016 at 11:08, Dimitry Andric via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Let's just drop the || !defined(__FreeBSD__) part. Btw, any idea what the > defined(__llvm__) part is supposed to accomplish?It was added in the same commit, and given the comment above I think it's probably so the test still runs on FreeBSD if Clang is self-hosting. Tim.
Pete Cooper via llvm-dev
2016-Jul-25 17:29 UTC
[llvm-dev] FreeBSD user willing to try fix a unit test?
> On Jul 23, 2016, at 4:01 PM, Tim Northover <t.p.northover at gmail.com> wrote: > > On 23 July 2016 at 11:08, Dimitry Andric via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Let's just drop the || !defined(__FreeBSD__) part. Btw, any idea what the >> defined(__llvm__) part is supposed to accomplish? > > It was added in the same commit, and given the comment above I think > it's probably so the test still runs on FreeBSD if Clang is > self-hosting.Yeah, thats the way I read it too. So this is really just trying to single out gcc 4.2.1 on FreeBSD as the illegal target. Thanks for running this Dimitry. I appreciate it. Can you commit the removal of #if or would you prefer me to? Thanks again, Pete> > Tim.
Dimitry Andric via llvm-dev
2016-Jul-26 06:57 UTC
[llvm-dev] FreeBSD user willing to try fix a unit test?
On 25 Jul 2016, at 19:29, Pete Cooper <peter_cooper at apple.com> wrote:> >> On Jul 23, 2016, at 4:01 PM, Tim Northover <t.p.northover at gmail.com> wrote: >> >> On 23 July 2016 at 11:08, Dimitry Andric via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >>> Let's just drop the || !defined(__FreeBSD__) part. Btw, any idea what the >>> defined(__llvm__) part is supposed to accomplish? >> >> It was added in the same commit, and given the comment above I think >> it's probably so the test still runs on FreeBSD if Clang is >> self-hosting. > Yeah, thats the way I read it too. So this is really just trying to single out gcc 4.2.1 on FreeBSD as the illegal target. > > Thanks for running this Dimitry. I appreciate it. > > Can you commit the removal of #if or would you prefer me to?Removed in r276730. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160726/44ba7f69/attachment.sig>