Renato Golin via llvm-dev
2016-May-17 19:43 UTC
[llvm-dev] [RFC] Helping release management
On 17 May 2016 at 20:40, Mehdi Amini <mehdi.amini at apple.com> wrote:> I don't see why? > The notion of title is already just a convention, any tool that look at the title has to filter it out of the full commit message in the first place AFAIK. > So I don't see any obstacle to have a regex that would match any part of the commit message.So, when I revert patches (using the git-svn script), it sets the title to: "Revert: <old title>" then writes on the body *only* "This reverts commit rNNNNN.". Unless the git-hook has a way look into rNNNN's commit message, or the PR is on the title, I don't know how it would match it... --renato
Mehdi Amini via llvm-dev
2016-May-17 19:44 UTC
[llvm-dev] [RFC] Helping release management
> On May 17, 2016, at 12:43 PM, Renato Golin <renato.golin at linaro.org> wrote: > > On 17 May 2016 at 20:40, Mehdi Amini <mehdi.amini at apple.com> wrote: >> I don't see why? >> The notion of title is already just a convention, any tool that look at the title has to filter it out of the full commit message in the first place AFAIK. >> So I don't see any obstacle to have a regex that would match any part of the commit message. > > So, when I revert patches (using the git-svn script), it sets the > title to: "Revert: <old title>" then writes on the body *only* "This > reverts commit rNNNNN.". > > Unless the git-hook has a way look into rNNNN's commit message, or the > PR is on the title, I don't know how it would match it...Updating the git-svn tool to find the PR in the original commit and adding the information in the revert seems appropriate to me here. -- Mehdi
Renato Golin via llvm-dev
2016-May-17 19:45 UTC
[llvm-dev] [RFC] Helping release management
On 17 May 2016 at 20:44, Mehdi Amini <mehdi.amini at apple.com> wrote:> Updating the git-svn tool to find the PR in the original commit and adding the information in the revert seems appropriate to me here.Indeed, that makes more sense. :) I like this approach as well. --renato
Hans Wennborg via llvm-dev
2016-May-17 19:46 UTC
[llvm-dev] [RFC] Helping release management
On Tue, May 17, 2016 at 12:44 PM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote:> >> On May 17, 2016, at 12:43 PM, Renato Golin <renato.golin at linaro.org> wrote: >> >> On 17 May 2016 at 20:40, Mehdi Amini <mehdi.amini at apple.com> wrote: >>> I don't see why? >>> The notion of title is already just a convention, any tool that look at the title has to filter it out of the full commit message in the first place AFAIK. >>> So I don't see any obstacle to have a regex that would match any part of the commit message. >> >> So, when I revert patches (using the git-svn script), it sets the >> title to: "Revert: <old title>" then writes on the body *only* "This >> reverts commit rNNNNN.". >> >> Unless the git-hook has a way look into rNNNN's commit message, or the >> PR is on the title, I don't know how it would match it... > > Updating the git-svn tool to find the PR in the original commit and adding the information in the revert seems appropriate to me here.It could also just quote the original commit message. I think that would be useful in general. But we're really getting into details now :-)