This might be slightly off topic, but I'd really like a way to be able to run the buildbots off a Phabricator Diff before committing. On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <klimek at google.com> wrote:> Unfortunately threading will be broken for changes currently under review > (new patches shouldn't have the problem). > I'm very sorry for this inconvenience :( > > On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <klimek at google.com> wrote: > >> Greetings llvm'ers, >> >> I'm working on an update to phabricator that brings our fork >> significantly closer to the upstream version, thus making maintenance much >> easier; this will allow us to upgrade more often. >> >> Upstream has fixed many issues and introduced new ways to customize the >> email flow, so >> >> a) while rolling out the new version I'll be fiddling with config >> settings; during that time, you might see emails that are not yet what >> we'll want the end-state to be; I'll announce on this thread once this is >> done >> >> b) the new version gives people more control over the emails; that means, >> if you're a phab user, you might get some emails that the list doesn't get >> (if you wish to); you can configure that from phab's email settings >> >> Once this is finished, please respond on this thread with your concerns / >> comments, or file bugs at >> https://llvm.org/bugs/enter_bug.cgi?product=Website >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=> >> . >> >> Cheers, >> /Manuel >> > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150702/eef4cac3/attachment.html>
Even further off topic, in phab wishlist land: It'd be awesome if it were capable of inferring extended patch context by looking at the svn repo/git mirrors (rather than requiring the person submitting the patch to re-upload with -U999). Jon On 7/2/15 10:52 AM, Keno Fischer wrote:> This might be slightly off topic, but I'd really like a way to be able > to run the buildbots off a Phabricator Diff before committing. > > On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <klimek at google.com > <mailto:klimek at google.com>> wrote: > > Unfortunately threading will be broken for changes currently under > review (new patches shouldn't have the problem). > I'm very sorry for this inconvenience :( > > On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <klimek at google.com > <mailto:klimek at google.com>> wrote: > > Greetings llvm'ers, > > I'm working on an update to phabricator that brings our fork > significantly closer to the upstream version, thus making > maintenance much easier; this will allow us to upgrade more often. > > Upstream has fixed many issues and introduced new ways to > customize the email flow, so > > a) while rolling out the new version I'll be fiddling with > config settings; during that time, you might see emails that are > not yet what we'll want the end-state to be; I'll announce on > this thread once this is done > > b) the new version gives people more control over the emails; > that means, if you're a phab user, you might get some emails > that the list doesn't get (if you wish to); you can configure > that from phab's email settings > > Once this is finished, please respond on this thread with your > concerns / comments, or file bugs at > https://llvm.org/bugs/enter_bug.cgi?product=Website > <https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=>. > > Cheers, > /Manuel > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > _______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >-- Jon Roelofs jonathan at codesourcery.com CodeSourcery / Mentor Embedded
On Thu, Jul 2, 2015 at 6:53 PM Keno Fischer <kfischer at college.harvard.edu> wrote:> This might be slightly off topic, but I'd really like a way to be able to > run the buildbots off a Phabricator Diff before committing. >Please file feature requests in the llvm bug tracker :)> > On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <klimek at google.com> wrote: > >> Unfortunately threading will be broken for changes currently under review >> (new patches shouldn't have the problem). >> I'm very sorry for this inconvenience :( >> >> On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <klimek at google.com> wrote: >> >>> Greetings llvm'ers, >>> >>> I'm working on an update to phabricator that brings our fork >>> significantly closer to the upstream version, thus making maintenance much >>> easier; this will allow us to upgrade more often. >>> >>> Upstream has fixed many issues and introduced new ways to customize the >>> email flow, so >>> >>> a) while rolling out the new version I'll be fiddling with config >>> settings; during that time, you might see emails that are not yet what >>> we'll want the end-state to be; I'll announce on this thread once this is >>> done >>> >>> b) the new version gives people more control over the emails; that >>> means, if you're a phab user, you might get some emails that the list >>> doesn't get (if you wish to); you can configure that from phab's email >>> settings >>> >>> Once this is finished, please respond on this thread with your concerns >>> / comments, or file bugs at >>> https://llvm.org/bugs/enter_bug.cgi?product=Website >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e=> >>> . >>> >>> Cheers, >>> /Manuel >>> >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150702/2c6468d1/attachment.html>
On Thu, Jul 2, 2015 at 7:27 PM Jonathan Roelofs <jonathan at codesourcery.com> wrote:> Even further off topic, in phab wishlist land: It'd be awesome if it > were capable of inferring extended patch context by looking at the svn > repo/git mirrors (rather than requiring the person submitting the patch > to re-upload with -U999). >Yea, this is hard, because detecting which path a patch goes against is hard (for example, if the patch path is a pure add for a new tools/sometool directory, is it in clang or llvm?) and requiring people to do global top-level llvm patches seems rather problematic. The workaround is to use arc diff (the command line tool).> > > Jon > > On 7/2/15 10:52 AM, Keno Fischer wrote: > > This might be slightly off topic, but I'd really like a way to be able > > to run the buildbots off a Phabricator Diff before committing. > > > > On Thu, Jul 2, 2015 at 9:01 AM, Manuel Klimek <klimek at google.com > > <mailto:klimek at google.com>> wrote: > > > > Unfortunately threading will be broken for changes currently under > > review (new patches shouldn't have the problem). > > I'm very sorry for this inconvenience :( > > > > On Thu, Jul 2, 2015 at 1:47 PM Manuel Klimek <klimek at google.com > > <mailto:klimek at google.com>> wrote: > > > > Greetings llvm'ers, > > > > I'm working on an update to phabricator that brings our fork > > significantly closer to the upstream version, thus making > > maintenance much easier; this will allow us to upgrade more > often. > > > > Upstream has fixed many issues and introduced new ways to > > customize the email flow, so > > > > a) while rolling out the new version I'll be fiddling with > > config settings; during that time, you might see emails that are > > not yet what we'll want the end-state to be; I'll announce on > > this thread once this is done > > > > b) the new version gives people more control over the emails; > > that means, if you're a phab user, you might get some emails > > that the list doesn't get (if you wish to); you can configure > > that from phab's email settings > > > > Once this is finished, please respond on this thread with your > > concerns / comments, or file bugs at > > https://llvm.org/bugs/enter_bug.cgi?product=Website > > < > https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_enter-5Fbug.cgi-3Fproduct-3DWebsite&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=Fvpa2efUGHSMDfoEJVFnwPMyOv6rPysb__oHeZH6MWI&s=cElWnsknBCk276Ol0-2baMtws6DjzsduR1uVw_4RSOI&e> >. > > > > Cheers, > > /Manuel > > > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu> > http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > > > > > > _______________________________________________ > > cfe-dev mailing list > > cfe-dev at cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev > > > > -- > Jon Roelofs > jonathan at codesourcery.com > CodeSourcery / Mentor Embedded >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150702/4cfbbbbe/attachment.html>