llvm dev - Jun 2015 - [LLVMdev] Who to assign as "reviewers" for a patch??

Dear LLVM devs,

I just submitted a patch: http://reviews.llvm.org/D10149. However,
Phabricator is warning me that "this revision needs review, but there are
no reviewers specified".

How should I determine who the reviewers should be?

Thanks,
Alex Dowad
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150605/b52d0dcd/attachment.html>

Look at the CODE_OWNERS.txt file, find the places your patch touches and 
who owns them, add those people to the review. At least that's what I've
been told previously when submitting patches.

-Neil.

On 05/06/15 10:54, Alex wrote:
> Dear LLVM devs,
>
> I just submitted a patch: http://reviews.llvm.org/D10149 
>
<https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10149&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=nZZqzbxhY7-xAfSiCDcR2N_iD2VxcU1KAZOU2nmF-50&s=cp7ZvsQqW1U9EYlIGQEAvE8Nmp1zXoM8rF3cezzN7IM&e=>.
> However, Phabricator is warning me that "this revision needs review, 
> but there are no reviewers specified".
>
> How should I determine who the reviewers should be?
>
> Thanks,
> Alex Dowad
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150605/4034d52e/attachment.html>

You can also look for people patching CFI- or X86- related code.

2015-06-05 13:11 GMT+03:00 Neil Henning <llvm at duskborn.com>:
>  Look at the CODE_OWNERS.txt file, find the places your patch touches and
> who owns them, add those people to the review. At least that's what
I've
> been told previously when submitting patches.
>
> -Neil.
>
>
> On 05/06/15 10:54, Alex wrote:
>
> Dear LLVM devs,
>
>  I just submitted a patch: http://reviews.llvm.org/D10149
>
<https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10149&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=nZZqzbxhY7-xAfSiCDcR2N_iD2VxcU1KAZOU2nmF-50&s=cp7ZvsQqW1U9EYlIGQEAvE8Nmp1zXoM8rF3cezzN7IM&e=>.
> However, Phabricator is warning me that "this revision needs review,
but
> there are no reviewers specified".
>
>  How should I determine who the reviewers should be?
>
>  Thanks,
> Alex Dowad
>
>
> _______________________________________________
> LLVM Developers mailing listLLVMdev at cs.uiuc.edu        
http://llvm.cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150605/2bdb4e01/attachment.html>