Renato Golin
2015-Mar-15 18:49 UTC
[LLVMdev] [cfe-dev] Bikeshedding commit message policy - Round 3 - Fight!
On 15 March 2015 at 16:31, Hal Finkel <hfinkel at anl.gov> wrote:> I don't want to code when to use them. But it makes sense to say, "If you want to include a title tag, do it like this...".I'm ok with that. So, do we have consensus? 1. Don't require, but recommend using [] for tags. 2. Don't specify attribution more than just "patch by Foo." and expect people to be sensible. Current scripts already work with a good variation anyway. cheers, --renato
Chris Lattner
2015-Mar-15 20:22 UTC
[LLVMdev] [cfe-dev] Bikeshedding commit message policy - Round 3 - Fight!
> On Mar 15, 2015, at 11:49 AM, Renato Golin <renato.golin at linaro.org> wrote: > > On 15 March 2015 at 16:31, Hal Finkel <hfinkel at anl.gov> wrote: >> I don't want to code when to use them. But it makes sense to say, "If you want to include a title tag, do it like this...". > > I'm ok with that. > > So, do we have consensus? > > 1. Don't require, but recommend using [] for tags. > > 2. Don't specify attribution more than just "patch by Foo." and expect > people to be sensible. Current scripts already work with a good > variation anyway.Can you post the entire revised diff that you want to include? Is it Diff 21913 on Phab? If so, LGTM. -Chris
Renato Golin
2015-Mar-15 20:33 UTC
[LLVMdev] [cfe-dev] Bikeshedding commit message policy - Round 3 - Fight!
On 15 March 2015 at 20:22, Chris Lattner <clattner at apple.com> wrote:> Can you post the entire revised diff that you want to include? Is it Diff 21913 on Phab? If so, LGTM.Hi Chris, Here's the final version: http://reviews.llvm.org/D8197 cheers, --renato