Daniel Sanders
2015-Jan-21 21:52 UTC
[LLVMdev] [3.6 Release] RC1 has been tagged, Testing Phase I begins
> > Shouldn't we be > > moving to CMake based release anyway? > > Oh, the joy of having two build systems. :-( > > As long as we have two, it doesn't really matter which one we use to > build the binaries, as users building from source will still rely on > both to be working. > > - HansOn that subject, are you aware that the release builds for linux don't build compiler-rt for any target other than x86/x86_64? I noticed it today when I tried the address sanitizer for Mips and found I didn't have the runtime. It seems that targets have to be explicitly enabled in tools/clang/runtime/compiler-rt/Makefile.
Hans Wennborg
2015-Jan-21 22:24 UTC
[LLVMdev] [3.6 Release] RC1 has been tagged, Testing Phase I begins
On Wed, Jan 21, 2015 at 1:52 PM, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote:>> > Shouldn't we be >> > moving to CMake based release anyway? >> >> Oh, the joy of having two build systems. :-( >> >> As long as we have two, it doesn't really matter which one we use to >> build the binaries, as users building from source will still rely on >> both to be working. >> >> - Hans > > On that subject, are you aware that the release builds for linux don't build compiler-rt for any target other than x86/x86_64? I noticed it today when I tried the address sanitizer for Mips and found I didn't have the runtime. > > It seems that targets have to be explicitly enabled in tools/clang/runtime/compiler-rt/Makefile.+kcc and samsonov who know the ASan build best Looks like when ASan support for MIPS landed in r211587, no one updated the autoconf build. That was before 3.5, so I guess that one also shipped without ASan support for MIPS.
Daniel Sanders
2015-Jan-22 09:47 UTC
[LLVMdev] [3.6 Release] RC1 has been tagged, Testing Phase I begins
> -----Original Message----- > From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf > Of Hans Wennborg > Sent: 21 January 2015 22:25 > To: Daniel Sanders > Cc: Renato Golin; llvmdev; cfe-dev; Ben Pope; Sylvestre Ledru; Dimitry > Andric; Sebastian Dreßler; Nikola Smiljanić; Kostya Serebryany; > vonosmas at gmail.com > Subject: Re: [3.6 Release] RC1 has been tagged, Testing Phase I begins > > On Wed, Jan 21, 2015 at 1:52 PM, Daniel Sanders > <Daniel.Sanders at imgtec.com> wrote: > >> > Shouldn't we be > >> > moving to CMake based release anyway? > >> > >> Oh, the joy of having two build systems. :-( > >> > >> As long as we have two, it doesn't really matter which one we use to > >> build the binaries, as users building from source will still rely on > >> both to be working. > >> > >> - Hans > > > > On that subject, are you aware that the release builds for linux don't build > compiler-rt for any target other than x86/x86_64? I noticed it today when I > tried the address sanitizer for Mips and found I didn't have the runtime. > > > > It seems that targets have to be explicitly enabled in > tools/clang/runtime/compiler-rt/Makefile. > > +kcc and samsonov who know the ASan build best > > Looks like when ASan support for MIPS landed in r211587, no one > updated the autoconf build. That was before 3.5, so I guess that one > also shipped without ASan support for MIPS.That's right. I didn't try to test ASan for 3.5 as I was focusing on getting little endian builds up and running. The main reason I mentioned the build issue on this thread is that AArch64 and ARM releases also ship without sanitizer libraries and I thought that might be surprising.
Alexey Samsonov
2015-Jan-27 23:32 UTC
[LLVMdev] [3.6 Release] RC1 has been tagged, Testing Phase I begins
On Wed, Jan 21, 2015 at 2:24 PM, Hans Wennborg <hans at chromium.org> wrote:> On Wed, Jan 21, 2015 at 1:52 PM, Daniel Sanders > <Daniel.Sanders at imgtec.com> wrote: > >> > Shouldn't we be > >> > moving to CMake based release anyway? > >> > >> Oh, the joy of having two build systems. :-( > >> > >> As long as we have two, it doesn't really matter which one we use to > >> build the binaries, as users building from source will still rely on > >> both to be working. > >> > >> - Hans > > > > On that subject, are you aware that the release builds for linux don't > build compiler-rt for any target other than x86/x86_64? I noticed it today > when I tried the address sanitizer for Mips and found I didn't have the > runtime. > > > > It seems that targets have to be explicitly enabled in > tools/clang/runtime/compiler-rt/Makefile. > > +kcc and samsonov who know the ASan build best > > Looks like when ASan support for MIPS landed in r211587, no one > updated the autoconf build. That was before 3.5, so I guess that one > also shipped without ASan support for MIPS. >ASan support for MIPS was indeed added recently. We currently only build MIPS version of runtime on MIPS-Linux host and only in CMake build (we don't cross-compile sanitizer runtimes, and it's barely feasible - e.g. we use a lot of system headers). autoconf build was not updated, and I would prefer not to touch it, that is, not to add new features there. -- Alexey Samsonov vonosmas at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150127/6af32374/attachment.html>