Hi, I tried to commit the Differential revision D3021 with the "arc commit" command. While it showed that the command succeeded and the Differential revision was closed, I can't find the revision anywhere in the SVN repository or the GIT mirror. Did I forget something? I tried a manual commit a few days ago and it worked. I've put the output of the "arc commit" command in a pastebin [2]. After executing the command, the status of the working copy was still clean and the output of "svn log" was the same as before, ie. no new commit was added. -Manuel [1] http://llvm-reviews.chandlerc.com/D3021 [2] http://bpaste.net/show/188153/
Hi, I normally do this: arc patch D3021 ninja check-all arc commit --revision D3021 I didn't think the 'arc patch' was actually required since the documentation led me to believe that 'arc commit' would do this if it wasn't already done but I've never tried to commit without it.> -----Original Message----- > From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] > On Behalf Of Manuel Jacob > Sent: 12 March 2014 19:56 > To: LLVMdev at cs.uiuc.edu > Subject: [LLVMdev] Arcanist commit "disappearing" > > Hi, > > I tried to commit the Differential revision D3021 with the "arc commit" > command. While it showed that the command succeeded and the > Differential revision was closed, I can't find the revision anywhere in the SVN > repository or the GIT mirror. Did I forget something? I tried a manual commit > a few days ago and it worked. I've put the output of the "arc commit" > command in a pastebin [2]. After executing the command, the status of the > working copy was still clean and the output of "svn log" was the same as > before, ie. no new commit was added. > > -Manuel > > [1] http://llvm-reviews.chandlerc.com/D3021 > [2] http://bpaste.net/show/188153/ > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Hi Daniel, On 2014-03-13 11:24, Daniel Sanders wrote:> Hi, > > I normally do this: > arc patch D3021 > ninja check-all > arc commit --revision D3021 > > I didn't think the 'arc patch' was actually required since the > documentation led me to believe that 'arc commit' would do this if it > wasn't already done but I've never tried to commit without it.Thank you! When applying the revision first, everythings works as expected. -Manuel>> -----Original Message----- >> From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] >> On Behalf Of Manuel Jacob >> Sent: 12 March 2014 19:56 >> To: LLVMdev at cs.uiuc.edu >> Subject: [LLVMdev] Arcanist commit "disappearing" >> >> Hi, >> >> I tried to commit the Differential revision D3021 with the "arc >> commit" >> command. While it showed that the command succeeded and the >> Differential revision was closed, I can't find the revision anywhere >> in the SVN >> repository or the GIT mirror. Did I forget something? I tried a >> manual commit >> a few days ago and it worked. I've put the output of the "arc commit" >> command in a pastebin [2]. After executing the command, the status of >> the >> working copy was still clean and the output of "svn log" was the same >> as >> before, ie. no new commit was added. >> >> -Manuel