similar to: [LLVMdev] Arcanist commit "disappearing"

On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi Dan, thanks for the feedback. > > On Mon, Dec 28, 2015 at 6:24 AM Dan Liew <dan at su-root.co.uk> wrote: > >> Hi, >> >> I recently tried reviewing/committing some of my code on >> Phabricator/Arcanist for the first time and I noticed that the docs

Hi, I recently tried reviewing/committing some of my code on Phabricator/Arcanist for the first time and I noticed that the docs [1] ask for feedback, so here it is! Phabricator functions reasonably well and it is a lot easier to write comments and respond to comments on particular parts of code as opposed to the old way of copy and pasting patches into e-mails sent to llvm-commits. Two minors

Hi all, We upgraded phabricator to use HTTPS by default. All HTTP traffic will now be redirected to HTTPS. Arcanist users: Please run: $ *arc install-certificate* to re-install the certificate. Thanks, Eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160714/efc26c7f/attachment.html>

Thanks for the catch Dead! I'll send out patches to update .arcconfig files to use https. On Thu, Jul 14, 2016 at 3:22 PM Dean Michael Berris <dberris at google.com> wrote: > Thanks Eric, > > If you're like me who started doing this and found some weird errors, you > may have to do the following instead: > > $ arc install-certificate

Hi, > Interesting, I don't read it that way :) I personally don't use arc to > commit. Sure the docs don't explicitly state that it's the only way. I just took that to be implied because the instructions for requesting a review provide multiple methods but the instructions for committing only mention using a single method. > Again, there is no one correct way. You can

> On Jan 7, 2016, at 9:57 AM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote: > >> >> On Jan 7, 2016, at 9:45 AM, David Blaikie via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> >> >> On Sun, Dec 27, 2015 at 10:59 PM, Manuel Klimek via llvm-dev <llvm-dev at lists.llvm.org

On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote: > I was always assuming that the suggested commit is assembled in the > PHP code run by arcanist command run locally. If indeed the arc > command requests the commit message from the server, I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data,

On Tue, Jan 7, 2020 at 5:35 PM Jonas Devlieghere <jonas at devlieghere.com> wrote: > On Tue, Jan 7, 2020 at 5:16 PM Bill Wendling via cfe-dev > <cfe-dev at lists.llvm.org> wrote: > > > > On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> > wrote: > >> > >> Hi Bill, > >> > >> On 01/07, Bill Wendling

Hi All, I just posted a review with arcanist (which I'm fairly new to) and it included a build status. How it got there is totally opaque to me, but my workflow was: Using git+svn (following the setup in https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn) make a change, commit with 'git commit', create review with 'air diff'. It would be cool if

Can we fix this in reviews.llvm.org's fork of phab? https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT. Jon On Fri, Dec 27, 2019 at 11:30 PM Mehdi AMINI via llvm-dev

On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> wrote: > Hi Bill, > > On 01/07, Bill Wendling via llvm-dev wrote: > > Then perhaps those opposed could suggest how to use Phabricator/Arcanist > so > > that I don't throw my keyboard through my monitor? > > Please explain your problems, w/o the hyperbole, so people can actually do >

I also find the "Reviewed by" tag useful (as well as the review link), for the same reasons. In fact, I don't even use arcanist to push commits, so I do it all by hand, and only include the "Reviewed by" and "Differential Revision" tags. On Fri, 27 Dec 2019 at 20:55, David Blaikie via llvm-dev < llvm-dev at lists.llvm.org> wrote: > I don't think

Hi Ben, (+llvm-dev since the email I'm replying to wasn't sent there) 2017-11-21 17:18 GMT+01:00 Ben Hamilton via cfe-dev <cfe-dev at lists.llvm.org> : > OK. I confirmed that Stephan's process to send out cross-repo diffs from > the monorepo is not affected by my proposal. > > I'm a bit late to the party, and I might just not have comprehended this correctly.

Hi, One takeaway for me from the recent Phabricator vs Github PR discussions was that arc (arcanist) can be a pain to set up and may pose a hurdle for some contributors. I think those points could be addressed relatively easily by adding a llvm-patch script (or an even better name) that allows users to create and apply patches from reviews.llvm.org using Phabricators API. In my experience, the

+1 to this. I will not deny that, for whatever reason, people don't seem to use Arcanist. Using PHP as the scripting language seems to be a major sticking point for people, since it is not typically preinstalled or required for normal LLVM development, in the way that Python is. I've done it, and it works for me. I think it makes more sense to try and standardize on the existing tool

The limitation with the "Reviewed by" line is that if you just use `arc` it indicates who was added as reviewer on the revision, but not who approved it. Because of this, I am wary of relying on this line for anything. If you want to know who reviewed a change, better click on the Differential Revision link and go to the source of truth. -- Mehdi On Thu, Jan 2, 2020 at 10:44 AM

Hello, on a fresh install (i.e. newly-cloned arcanist and llvm-project), I get this. Any ideas? Thanks! arc install-certificate CONNECT Connecting to "https://reviews.llvm.org/api/"... Usage Exception: Failed to connect to server (https://reviews.llvm.org/api/): [HTTP/500] Internal Server Error As received by the server, this request had a nonzero content length but no POST data.

Forgot to mention: > Also, how would arcanist pick up two callsigns here? Wouldn't it just pick the from the closest surrounding .arcconfig? The review request will belong to a single repository, as you noticed (from the closest .arcconfig to where the arc command was invoked). However, when commits land, they will be imported under either one (rL for LLVM diffs) or two (rL + rC for e.g.

I'm sure I've seen many commits with both "Reviewed by:" and "Reviewers:" tags, which look to have been done with arc (though I can't be sure). How were those generated? On Sat, 4 Jan 2020 at 19:12, David Blaikie <dblaikie at gmail.com> wrote: > Yeah, I tend to prune it down myself - and if the list has only one name > on it, it's usually a pretty

I thought so, initially. But I'm able to log in to reviews.llvm.org. Also, I assume install-certificate is before any of these considerations? On Wed, Apr 8, 2020 at 6:53 PM David Blaikie <dblaikie at gmail.com> wrote: > Hmm - I'm running a pretty old version & seems to be working for me: > > $ arc version > > arcanist 3b6b523c2b236e3724a1e115f126cb6fd05fa128 (18