llvm dev - Dec 2013 - [LLVMdev] Switching to the new MingW ABI

On 11 December 2013 05:41, Kai Nacke <kai.nacke at redstar.de>
wrote:
> Maybe we should also change the stack probing code. I think ___chkstk_ms is
> used since gcc 4.6. It simplifies the prologue generation code a bit.
I just checked gcc 4.6 and looks like you are right, it uses ___chkstk_ms.

LGTM. We should probably commit this first, since it is common for gcc
4.6 and newer.

Cheers,
Rafael

Hi Rafael,

is more approval needed to commit?

Regards,
Kai

On 12.12.2013 00:56, Rafael Espíndola wrote:
> On 11 December 2013 05:41, Kai Nacke <kai.nacke at redstar.de> wrote:
>> Maybe we should also change the stack probing code. I think
___chkstk_ms is
>> used since gcc 4.6. It simplifies the prologue generation code a bit.
>
> I just checked gcc 4.6 and looks like you are right, it uses ___chkstk_ms.
>
> LGTM. We should probably commit this first, since it is common for gcc
> 4.6 and newer.
>
> Cheers,
> Rafael
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>

On 12 December 2013 14:01, Kai Nacke <kai.nacke at redstar.de>
wrote:
> Hi Rafael,
>
> is more approval needed to commit?
No, go for it.

Cheers,
Rafael