llvm dev - Nov 2013 - [LLVMdev] [PATCH] CalculateSpillWeights does not need to be a pass

Based on discussions with Lang Hames and Jakob Stoklund Olesen at the
hacker's lab, and in the light of upcoming work on the PBQP register
allocator, it was though that CalcSpillWeights does not need to be a pass.
This change will enable to customize / tune the spill weight computation
depending on the allocator.

Update the documentation style while there.

I also intend to take VirtRegAuxInfo out of line in a later patch as this
is really a helper class for spill weight (re) computation.

Cheers,
--
Arnaud
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131108/826c63c0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CalculateSpillWeights-does-not-need-to-be-a-pass.patch
Type: text/x-patch
Size: 10307 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131108/826c63c0/attachment.bin>

On Nov 8, 2013, at 7:40 AM, Arnaud Allard de Grandmaison <arnaud.adegm at
gmail.com> wrote:
> Based on discussions with Lang Hames and Jakob Stoklund Olesen at the
hacker's lab, and in the light of upcoming work on the PBQP register
allocator, it was though that CalcSpillWeights does not need to be a pass. This
change will enable to customize / tune the spill weight computation depending on
the allocator.
> 
> Update the documentation style while there.
> 
> I also intend to take VirtRegAuxInfo out of line in a later patch as this
is really a helper class for spill weight (re) computation.
> 
> Cheers,
> --
> Arnaud
> <0001-CalculateSpillWeights-does-not-need-to-be-a-pass.patch>
LGTM.

Thanks,
/jakob

Committed at r194269

Thanks Jakob !

Cheers,
--
Arnaud


On Fri, Nov 8, 2013 at 6:34 PM, Jakob Stoklund Olesen <stoklund at
2pi.dk>wrote:
>
> On Nov 8, 2013, at 7:40 AM, Arnaud Allard de Grandmaison <
> arnaud.adegm at gmail.com> wrote:
>
> > Based on discussions with Lang Hames and Jakob Stoklund Olesen at the
> hacker's lab, and in the light of upcoming work on the PBQP register
> allocator, it was though that CalcSpillWeights does not need to be a pass.
> This change will enable to customize / tune the spill weight computation
> depending on the allocator.
> >
> > Update the documentation style while there.
> >
> > I also intend to take VirtRegAuxInfo out of line in a later patch as
> this is really a helper class for spill weight (re) computation.
> >
> > Cheers,
> > --
> > Arnaud
> > <0001-CalculateSpillWeights-does-not-need-to-be-a-pass.patch>
>
> LGTM.
>
> Thanks,
> /jakob
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20131108/91a0002b/attachment.html>