llvm dev - Oct 2013 - [LLVMdev] Add Support For .bss Named Section Directive For Darwin Targets

I believe it's a feature missing in MC -
https://github.com/opensource-apple/cctools/blob/4da58fd2fc026317ed9e9ef1feabf21ed0bb7a81/cctools-836/as/i386.c
line
539 adds support for the .bss directive if certain variables are defined,
and mainline gas supports it on all ARM targets:
https://sourceware.org/binutils/docs/as/ARM-Directives.html . Supporting
the directive on all Darwin targets could be considered an extension
though. Thanks -

On Sunday, 29 September 2013, Rafael Espíndola wrote:
> Is this an extension to what cctools' assembler provides or a missing
> feature in MC?
>
> On 28 September 2013 18:48, Nicholas White <n.j.white at
gmail.com<javascript:;>>
> wrote:
> > Hi - I've attached a patch to make the assembly parser recognise
the
> > .bss directive on Darwin targets as a switch to the (__DATA,__bss)
> > section. The ELF & COFF assembly parsers already recongnise the
.bss
> > directive. I've added a test case for it too. Thanks -
> >
> > Nick
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu <javascript:;>        
http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130929/6abec912/attachment.html>

LGTM

On 29 September 2013 06:08, Nicholas White <n.j.white at gmail.com>
wrote:
> I believe it's a feature missing in MC -
>
https://github.com/opensource-apple/cctools/blob/4da58fd2fc026317ed9e9ef1feabf21ed0bb7a81/cctools-836/as/i386.c
> line 539 adds support for the .bss directive if certain variables are
> defined, and mainline gas supports it on all ARM targets:
> https://sourceware.org/binutils/docs/as/ARM-Directives.html . Supporting
the
> directive on all Darwin targets could be considered an extension though.
> Thanks -
>
> On Sunday, 29 September 2013, Rafael Espíndola wrote:
>>
>> Is this an extension to what cctools' assembler provides or a
missing
>> feature in MC?
>>
>> On 28 September 2013 18:48, Nicholas White <n.j.white at
gmail.com> wrote:
>> > Hi - I've attached a patch to make the assembly parser
recognise the
>> > .bss directive on Darwin targets as a switch to the (__DATA,__bss)
>> > section. The ELF & COFF assembly parsers already recongnise
the .bss
>> > directive. I've added a test case for it too. Thanks -
>> >
>> > Nick
>> >
>> > _______________________________________________
>> > LLVM Developers mailing list
>> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>> >

Thanks - how would I go about getting this committed?

Nick

On 30 September 2013 13:50, Rafael Espíndola <rafael.espindola at
gmail.com> wrote:
> LGTM
>
> On 29 September 2013 06:08, Nicholas White <n.j.white at gmail.com>
wrote:
>> I believe it's a feature missing in MC -
>>
https://github.com/opensource-apple/cctools/blob/4da58fd2fc026317ed9e9ef1feabf21ed0bb7a81/cctools-836/as/i386.c
>> line 539 adds support for the .bss directive if certain variables are
>> defined, and mainline gas supports it on all ARM targets:
>> https://sourceware.org/binutils/docs/as/ARM-Directives.html .
Supporting the
>> directive on all Darwin targets could be considered an extension
though.
>> Thanks -
>>
>> On Sunday, 29 September 2013, Rafael Espíndola wrote:
>>>
>>> Is this an extension to what cctools' assembler provides or a
missing
>>> feature in MC?
>>>
>>> On 28 September 2013 18:48, Nicholas White <n.j.white at
gmail.com> wrote:
>>> > Hi - I've attached a patch to make the assembly parser
recognise the
>>> > .bss directive on Darwin targets as a switch to the
(__DATA,__bss)
>>> > section. The ELF & COFF assembly parsers already
recongnise the .bss
>>> > directive. I've added a test case for it too. Thanks -
>>> >
>>> > Nick
>>> >
>>> > _______________________________________________
>>> > LLVM Developers mailing list
>>> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>> >