Pawel Wodnicki
2012-Dec-11 18:12 UTC
[LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
Chris,> On Nov 29, 2012, at 2:13 PM, Tom Stellard <tom at stellard.net> wrote: >> Hi Dimitri, >> >> Thanks for taking a look at the code. >> >> I went ahead and made all of these changes, and I reviewed the doxygen section >> of the Coding Standards document and updated the comments as well. >> I also fixed the issue mentioned by Ben with braces on their own line. >> >> I've posted an updated patch here: >> http://people.freedesktop.org/~tstellar/llvm/Nov29/ >> >> Also in that directory are two patches which show the changes since the >> previous version of R600.patch. >> >> Hopefully this patch looks a little better. > > I'm obviously not an expert on this architecture, but the patch looks basically ok to me. Please commit!Just ToT or also 3.2?> > -Chris
Chris Lattner
2012-Dec-11 18:40 UTC
[LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
On Dec 11, 2012, at 10:12 AM, Pawel Wodnicki <root at 32bitmicro.com> wrote:> Chris, > >> On Nov 29, 2012, at 2:13 PM, Tom Stellard <tom at stellard.net> wrote: >>> Hi Dimitri, >>> >>> Thanks for taking a look at the code. >>> >>> I went ahead and made all of these changes, and I reviewed the doxygen section >>> of the Coding Standards document and updated the comments as well. >>> I also fixed the issue mentioned by Ben with braces on their own line. >>> >>> I've posted an updated patch here: >>> http://people.freedesktop.org/~tstellar/llvm/Nov29/ >>> >>> Also in that directory are two patches which show the changes since the >>> previous version of R600.patch. >>> >>> Hopefully this patch looks a little better. >> >> I'm obviously not an expert on this architecture, but the patch looks basically ok to me. Please commit! > > Just ToT or also 3.2?Just ToT! -Chris
Possibly Parallel Threads
- [LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
- [LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
- [LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
- [LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release
- [LLVMdev] [llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release