llvm dev - Sep 2012 - [LLVMdev] patch to enable response file support in ParseCommandLineOptions

Hi,

I am sending a patch to enable response file support in ParseCommandLineOptions.
With this change, all llvm tools will support response file. This helps overcome
the command line length limit which we encountered recently.

Index: include/llvm/Support/CommandLine.h
==================================================================---
include/llvm/Support/CommandLine.h  (revision 164408)
+++ include/llvm/Support/CommandLine.h  (working copy)
@@ -42,7 +42,7 @@
//
void ParseCommandLineOptions(int argc, const char * const *argv,
                              const char *Overview = 0,
-                             bool ReadResponseFiles = false);
+                             bool ReadResponseFiles = true);

//===----------------------------------------------------------------------===//
// ParseEnvironmentOptions - Environment variable option processing alternate

Sam
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120921/0fb08888/attachment.html>

Hi Sam, please add a testcase.  Does this cause any regressions?

Ciao, Duncan.
> I am sending a patch to enable response file support in
ParseCommandLineOptions.
> With this change, all llvm tools will support response file. This helps
overcome
> the command line length limit which we encountered recently.
>
> Index: include/llvm/Support/CommandLine.h
>
> ==================================================================>
> --- include/llvm/Support/CommandLine.h  (revision 164408)
>
> +++ include/llvm/Support/CommandLine.h  (working copy)
>
> @@ -42,7 +42,7 @@
>
> //
>
> void ParseCommandLineOptions(int argc, const char * const *argv,
>
>                                const char *Overview = 0,
>
> -                             bool ReadResponseFiles = false);
>
> +                             bool ReadResponseFiles = true);
>
>
//===----------------------------------------------------------------------===//
>
> // ParseEnvironmentOptions - Environment variable option processing
alternate
>
> Sam
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

Hi Duncan,

The patch for the test and the change is attached. I ran the regression test and
no regressions found.

Sam

-----Original Message-----
From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On
Behalf Of Duncan Sands
Sent: Saturday, September 22, 2012 6:15 AM
To: llvmdev at cs.uiuc.edu
Subject: Re: [LLVMdev] patch to enable response file support in
ParseCommandLineOptions

Hi Sam, please add a testcase.  Does this cause any regressions?

Ciao, Duncan.
> I am sending a patch to enable response file support in
ParseCommandLineOptions.
> With this change, all llvm tools will support response file. This 
> helps overcome the command line length limit which we encountered recently.
>
> Index: include/llvm/Support/CommandLine.h
>
> ==================================================================>
> --- include/llvm/Support/CommandLine.h  (revision 164408)
>
> +++ include/llvm/Support/CommandLine.h  (working copy)
>
> @@ -42,7 +42,7 @@
>
> //
>
> void ParseCommandLineOptions(int argc, const char * const *argv,
>
>                                const char *Overview = 0,
>
> -                             bool ReadResponseFiles = false);
>
> +                             bool ReadResponseFiles = true);
>
> //===-----------------------------------------------------------------
> -----===//
>
> // ParseEnvironmentOptions - Environment variable option processing 
> alternate
>
> Sam
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
_______________________________________________
LLVM Developers mailing list
LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_response.txt
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20120924/2491773f/attachment.txt>