Andy Gibbs
2012-Jul-31 09:35 UTC
[LLVMdev] [lld] Patch to incorporate lld test-suite into "make check-all"
Hi again, Any interest in this patch to incorporate lld testing into "make check-all" when lld built as part of llvm? Is this the best place to post patches for lld? I've attached it again here to include a missing dependency. Cheers Andy On Thursday, July 26, 2012 1:45 PM, Andy Gibbs wrote:> Hi, > > Attached is a patch which incorporates the lld test-suite into llvm's "make > check-all" if lld is built within llvm. Please could someone review this > for me. > > I've hand-amended the patch so that it should be easier to review. The > majority of the patch is simply changing the indent once inside and else()/ > endif() block. Beyond that, I've standardised the test target name to > "check-lld", but retained the legacy "lld-test" target. > > Regards > Andy-------------- next part -------------- A non-text attachment was scrubbed... Name: lld-tests.diff Type: application/octet-stream Size: 3521 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120731/27e72ede/attachment.obj>
Michael Spencer
2012-Jul-31 18:46 UTC
[LLVMdev] [lld] Patch to incorporate lld test-suite into "make check-all"
On Tue, Jul 31, 2012 at 2:35 AM, Andy Gibbs <andyg1001 at hotmail.co.uk> wrote:> Hi again, > > Any interest in this patch to incorporate lld testing into "make check-all" > when lld built as part of llvm? Is this the best place to post patches for > lld? > > I've attached it again here to include a missing dependency. > > Cheers > Andy > > > On Thursday, July 26, 2012 1:45 PM, Andy Gibbs wrote: >> Hi, >> >> Attached is a patch which incorporates the lld test-suite into llvm's "make >> check-all" if lld is built within llvm. Please could someone review this >> for me. >> >> I've hand-amended the patch so that it should be easier to review. The >> majority of the patch is simply changing the indent once inside and else()/ >> endif() block. Beyond that, I've standardised the test target name to >> "check-lld", but retained the legacy "lld-test" target. >> >> Regards >> AndyCommitted as r161067. Thanks! Can you create futures patches relative to the lld directory instead of llvm? I don't have lld checked out inside llvm. - Michael Spencer
Andy Gibbs
2012-Jul-31 19:00 UTC
[LLVMdev] [lld] Patch to incorporate lld test-suite into "make check-all"
On Tuesday, July 31, 2012 8:46 PM, Michael Spencer wrote:> Committed as r161067. Thanks! > > Can you create futures patches relative to the lld directory instead > of llvm? I don't have lld checked out inside llvm.Sorry, my mistake. But thanks for committing it. Cheers Andy