Chandler Carruth
2012-Jun-29 11:40 UTC
[LLVMdev] Question for users of the CMake build system:
Do you use the LLVM_INCLUDE_TESTS setting? If so, what for? It is documented to preclude the inclusion *unittests* in the build. What it actually does in preclude *all* LLVM testing (unit and regression), but only unittests for Clang. The Clang regression tests continue to be built and run. My preference is simply to remove it if none have an important use case. If they do, I would like to understand it and come up with some sane and consistent semantic model to support it. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120629/e97c6791/attachment.html>
James Molloy
2012-Jun-29 12:52 UTC
[LLVMdev] [cfe-dev] Question for users of the CMake build system:
Hi, We use CMake but don't use that setting. Cheers, James On 29 June 2012 12:40, Chandler Carruth <chandlerc at google.com> wrote:> Do you use the LLVM_INCLUDE_TESTS setting? If so, what for? > > > It is documented to preclude the inclusion *unittests* in the build. > > What it actually does in preclude *all* LLVM testing (unit and regression), > but only unittests for Clang. The Clang regression tests continue to be > built and run. > > > My preference is simply to remove it if none have an important use case. If > they do, I would like to understand it and come up with some sane and > consistent semantic model to support it. > > _______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >
Michael Spencer
2012-Jun-29 20:06 UTC
[LLVMdev] [cfe-dev] Question for users of the CMake build system:
On Fri, Jun 29, 2012 at 4:40 AM, Chandler Carruth <chandlerc at google.com> wrote:> Do you use the LLVM_INCLUDE_TESTS setting? If so, what for? > > > It is documented to preclude the inclusion *unittests* in the build. > > What it actually does in preclude *all* LLVM testing (unit and regression), > but only unittests for Clang. The Clang regression tests continue to be > built and run. > > > My preference is simply to remove it if none have an important use case. If > they do, I would like to understand it and come up with some sane and > consistent semantic model to support it.I believe this was added because the unit tests used to clutter up the IDE because there were so many. But now they are in folders so it doesn't matter for VS, it may still matter for XCode. I vote to remove it if no one is using it. If we actually do have a usecase for it it definitely needs to be cleaned up. - Michael Spencer
Robinson, Paul
2012-Jun-29 23:39 UTC
[LLVMdev] [cfe-dev] Question for users of the CMake build system:
What James said. --paulr ________________________________________ From: cfe-dev-bounces at cs.uiuc.edu [cfe-dev-bounces at cs.uiuc.edu] on behalf of James Molloy [james at jamesmolloy.co.uk] Sent: Friday, June 29, 2012 5:52 AM To: Chandler Carruth Cc: clang-dev Developers; LLVM Developers Mailing List Subject: Re: [cfe-dev] Question for users of the CMake build system: Hi, We use CMake but don't use that setting. Cheers, James On 29 June 2012 12:40, Chandler Carruth <chandlerc at google.com> wrote:> Do you use the LLVM_INCLUDE_TESTS setting? If so, what for? > > > It is documented to preclude the inclusion *unittests* in the build. > > What it actually does in preclude *all* LLVM testing (unit and regression), > but only unittests for Clang. The Clang regression tests continue to be > built and run. > > > My preference is simply to remove it if none have an important use case. If > they do, I would like to understand it and come up with some sane and > consistent semantic model to support it. > > _______________________________________________ > cfe-dev mailing list > cfe-dev at cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev >_______________________________________________ cfe-dev mailing list cfe-dev at cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
Reasonably Related Threads
- [LLVMdev] [cfe-dev] Question for users of the CMake build system:
- [cfe-dev] Proposal: pull benchmark library to the LLVM main repository
- [LLVMdev] AddressSanitizer+CMake unittest question
- [LLVMdev] [cfe-commits] r157260 - in /cfe/trunk: include/clang/Rewrite/Rewriter.h lib/Rewrite/Rewriter.cpp unittests/CMakeLists.txt unittests/Tooling/RewriterTest.cpp unittests/Tooling/RewriterTestContext.h
- [LLVMdev] Any objections to my importing GoogleMock to go with GoogleTest in LLVM?