On Jun 27, 2012, at 4:20 PM, Eric Christopher wrote:> > On Jun 27, 2012, at 4:08 PM, Bill Wendling <wendling at apple.com> wrote: > >> Hi all, >> >> This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to include/llvm/DebugInfo.h. >> >> Why? Because this module has nothing to do with analysis. It simply defines an interface to the debug info MDNodes. In fact, the lib/VMCore/AsmWriter.cpp file performs a layering violation, because it calculates the DWARF tag from this debug info, which is more appropriately calculated via the debug info module. It could eventually allow us to use the debug info module's comment printer to generate fuller comments in the .ll file. >> >> Okay to commit? >> >> -bw >> >> <clang-debuginfo.patch><debuginfo.patch> > > Sure, I'm ok with that. >Done. Thanks! -bw
On Thu, Jun 28, 2012 at 4:22 AM, Bill Wendling <wendling at apple.com> wrote:> On Jun 27, 2012, at 4:20 PM, Eric Christopher wrote: > > > > > On Jun 27, 2012, at 4:08 PM, Bill Wendling <wendling at apple.com> wrote: > > > >> Hi all, > >> > >> This patch, though large, simply moves lib/Analysis/DebugInfo.cpp to > lib/VMCore/DebugInfo.cpp and include/llvm/Analysis/DebugInfo.h to > include/llvm/DebugInfo.h. > >> > >> Why? Because this module has nothing to do with analysis. It simply > defines an interface to the debug info MDNodes. In fact, the > lib/VMCore/AsmWriter.cpp file performs a layering violation, because it > calculates the DWARF tag from this debug info, which is more appropriately > calculated via the debug info module. It could eventually allow us to use > the debug info module's comment printer to generate fuller comments in the > .ll file. > >> > >> Okay to commit? > >> > >> -bw > >> > >> <clang-debuginfo.patch><debuginfo.patch> > > > > Sure, I'm ok with that. > > > Done. Thanks! >Now include/llvm folder has the following files: DebugInfo.h - describes debug info MDNodes DebugInfo/DIContext.h - defines an abstract debug info context for fetching debug info from object files. It is currently used in llvm-dwarfdump and I hope to use it in llvm-based symbolizer. Just wanted to ask if you're fine with this layout and don't find it confusing.> _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-- Alexey Samsonov, MSK -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120628/f36ca150/attachment.html>
Eric Christopher
2012-Jun-28 18:09 UTC
[LLVMdev] [PATCH] Moving DebugInfo module to VMCore
On Jun 27, 2012, at 11:58 PM, Alexey Samsonov <samsonov at google.com> wrote:> Just wanted to ask if you're fine with this layout and don't find it confusing. >It's a step forward :) I don't mind moving things around as they make sense. -eric