Nikola Smiljanic
2011-Oct-10 07:43 UTC
[LLVMdev] [cfe-dev] Unicode path handling on Windows
ping -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111010/14a4f67c/attachment.html>
I would still fix the code formatting even though you merely uncommented it (just to be consistent with the rest of the code). But functionally-speaking, I think your patches are good. ~Aaron On Mon, Oct 10, 2011 at 2:43 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:> ping
Nikola Smiljanic
2011-Oct-11 07:26 UTC
[LLVMdev] [cfe-dev] Unicode path handling on Windows
Fixed formatting. On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at aaronballman.com>wrote:> I would still fix the code formatting even though you merely > uncommented it (just to be consistent with the rest of the code). But > functionally-speaking, I think your patches are good. > > ~Aaron >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: clang.patch Type: application/octet-stream Size: 15803 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: application/octet-stream Size: 4685 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment-0001.obj>
Reasonably Related Threads
- [LLVMdev] [cfe-dev] Unicode path handling on Windows
- [LLVMdev] [cfe-dev] Unicode path handling on Windows
- [LLVMdev] [cfe-dev] Unicode path handling on Windows
- [LLVMdev] [cfe-dev] Unicode path handling on Windows
- [LLVMdev] [cfe-dev] Unicode path handling on Windows