search for: smiljan

On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote: > Was there an rc3 that I missed? > It's not tagged if there was. I've tested and uploaded 3.5.1 final for x86_64-ubuntu-14.04. I think the rc2 build required a newer libstdc++ than exists on Ubuntu 14.04, but the final build should be good. Ben

Many of them are already live: http://llvm.org/releases/download.html#3.5 On 15/01/2015 01:50, Nikola Smiljanic wrote: > In that case are we supposed to build final binaries for 3.5.1? > > On Thu, Jan 15, 2015 at 11:49 AM, Ben Pope <benpope81 at gmail.com > <mailto:benpope81 at gmail.com>> wrote: > > > On Thursday, January 15, 2015 06:55 AM, Nikola Smiljanic wrote: >...

...dle and is basically the same thing. This would require refactoring FileSystemStatCache to use a new structure in place of stat that could be shared between Windows and Unix. This would be a lot of small changes but seems like it would be fairly straightforward. On Oct 3, 2011, at 9:21 AM, Nikola Smiljanic wrote: > towlower doesn't seem to work with my test string in Cyrillic. This function does locale-specific conversion, is this what we want? > > Here's the whole thing, with all the calls to ::stat replaced with llvm::sys::fs::Stat. > > On Fri, Sep 30, 2011 at 8:04 PM, B...

...e thing. > This would require refactoring FileSystemStatCache to use a new structure in > place of stat that could be shared between Windows and Unix. This would be a > lot of small changes but seems like it would be fairly straightforward. > > > On Oct 3, 2011, at 9:21 AM, Nikola Smiljanic wrote: > > towlower doesn't seem to work with my test string in Cyrillic. This > function does locale-specific conversion, is this what we want? > > Here's the whole thing, with all the calls to ::stat replaced with > llvm::sys::fs::Stat. > > On Fri, Sep 30, 2011 a...

You can use _iswupper and _towlower instead of CharLowerBuffW. They don't require windows.h and work with /Za. On Sep 30, 2011, at 12:24 AM, Nikola Smiljanic wrote: > I tried to do the conversion to lowercase inside GetFullPath by adding an additional bool parameter to this function. It's not perfect but seems much better than repeating the whole UTF8 to UTF16 and UTF16 to UTF8 conversion again. The problem I have is with access to CharLowerBu...

...::stat replaced with llvm::sys::fs::Stat. On Fri, Sep 30, 2011 at 8:04 PM, Bryce Cogswell <bryceco at gmail.com> wrote: > You can use _iswupper and _towlower instead of CharLowerBuffW. They don't > require windows.h and work with /Za. > > On Sep 30, 2011, at 12:24 AM, Nikola Smiljanic wrote: > > I tried to do the conversion to lowercase inside GetFullPath by adding an > additional bool parameter to this function. It's not perfect but seems much > better than repeating the whole UTF8 to UTF16 and UTF16 to UTF8 conversion > again. The problem I have is with ac...

On Tue, Sep 6, 2011 at 11:28 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > The problem is not in the functions that return multibyte strings (the > multibyte string is coming from argv) argv is implicitly the return from a UTF16->multibyte conversion (i.e. it's lossy). -Eli

Right, but maybe if you switch to using tolower_l() and pass an appropriate locale you can get it to work the same way. I'm not sure what locale that would have to be, but it needs to match whatever NTFS uses for its $upcase file. On Oct 3, 2011, at 12:19 PM, Nikola Smiljanic wrote: > CharLowerW does the right thing. But I still need Windows.h to use it :) > > On Mon, Oct 3, 2011 at 8:43 PM, Bryce Cogswell <bryceco at gmail.com> wrote: > Locale-specific is not what we want, but I don't believe Windows exposes an alternative API that does what w...

...rcaseString, so you can use MultiByteToWideChar and CharLowerBuffW directly there, and not call the LowercaseString function. I don't think there are any other places where LowercaseString is called with non-ascii data, so you can punt on fixing it for now. On Sep 28, 2011, at 10:11 PM, Nikola Smiljanic wrote: > I have a problem with Lowercase and Uppercase functions. These are broken on all platforms, not only Window, so I can't just #ifdef and use CharLowerBuffW. I need a portable way to convert from UTF8 to UTF16. There is set of functions inside clang/Basic/ConvertUTF, but LLVM can...

...used from there. > > > > I'll commit that patch to the trunk and ask Tom for permission to merge it. > > > > From: sebastian.dressler at gmail.com [mailto:sebastian.dressler at gmail.com] > Sent: 16 December 2014 05:20 > To: Daniel Sanders > Cc: Ben Pope; Nikola Smiljanic; llvmdev > Subject: Re: [LLVMdev] 3.5.1 Testing Phase Begins > > > > > > On 15.12.2014, at 23:01, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote: > > > > From: sebastian.dressler at gmail.com [sebastian.dressler at gmail.com] > Sent: 15 December 2014...

...and thought I was replying to you and things got confused from there. I'll commit that patch to the trunk and ask Tom for permission to merge it. From: sebastian.dressler at gmail.com [mailto:sebastian.dressler at gmail.com] Sent: 16 December 2014 05:20 To: Daniel Sanders Cc: Ben Pope; Nikola Smiljanic; llvmdev Subject: Re: [LLVMdev] 3.5.1 Testing Phase Begins On 15.12.2014, at 23:01, Daniel Sanders <Daniel.Sanders at imgtec.com<mailto:Daniel.Sanders at imgtec.com>> wrote: From: sebastian.dressler at gmail.com<mailto:sebastian.dressler at gmail.com> [sebastian.dressler at g...

On Wed, Sep 7, 2011 at 12:20 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > So what are you exactly saying? Somebody proposed using GetCommandLine > instead of using argv directly. And what about my other points about ::open > and ::stat? Because of the way Windows works, the only fully correct solution is to never touch t...

...use MultiByteToWideChar and CharLowerBuffW directly there, and > not call the LowercaseString function. I don't think there are any other > places where LowercaseString is called with non-ascii data, so you can punt > on fixing it for now. > > On Sep 28, 2011, at 10:11 PM, Nikola Smiljanic wrote: > > I have a problem with Lowercase and Uppercase functions. These are broken > on all platforms, not only Window, so I can't just #ifdef and use CharLowerBuffW. > I need a portable way to convert from UTF8 to UTF16. There is set of > functions inside clang/Basic/Convert...

...FullPathName in order to expand any 8.3 path components, but this is an expensive function so I wouldn't do it unless absolutely necessary. There is also a call to _fullpath in there that needs to be changed to _wfullpath. The rest of the patch looks good. On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. > > I have only one more questions: > > 1. _wopen accepts _stat64i32 instead of stat st...

...t; path components, but this is an expensive function so I wouldn't do it > unless absolutely necessary. > > There is also a call to _fullpath in there that needs to be changed to > _wfullpath. > > The rest of the patch looks good. > > On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > > Here's a new patch that fixes all the issues mentioned before. Note that > this isn't final, I didn't want to replace all calls to ::stat so that it's > easier to review. > > I have only one more questions: > > 1. _wopen accepts _stat64i32 instea...

...:45, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote: > >> -----Original Message----- >> From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] >> On Behalf Of Sebastian Dreßler >> Sent: 15 December 2014 14:08 >> Cc: Ben Pope; Nikola Smiljanic; llvmdev >> Subject: Re: [LLVMdev] 3.5.1 Testing Phase Begins >> >> 2014-12-15 13:00 GMT+01:00 Daniel Sanders <Daniel.Sanders at imgtec.com>: >>>> LLVM: CodeGen/Mips/cconv/arguments-struct.ll >>> >>> Do you have the verbose lit output for th...

...he access timestamp. I've started the test-suite for both of them. ________________________________________ From: llvmdev-bounces at cs.uiuc.edu [llvmdev-bounces at cs.uiuc.edu] on behalf of Hans Wennborg [hans at chromium.org] Sent: 19 December 2014 23:50 To: Tom Stellard Cc: Ben Pope; Nikola Smiljanic; llvmdev Subject: Re: [LLVMdev] 3.5.1 Testing Phase II Begins On Fri, Dec 19, 2014 at 2:35 PM, Tom Stellard <tom at stellard.net> wrote: > Hi, > > I've just tagged 3.5.1-rc2, so testing can begin. Remember to use the 3.5 > branch of the test-suite. If you have any questio...

So what are you exactly saying? Somebody proposed using GetCommandLine instead of using argv directly. And what about my other points about ::open and ::stat? On Wed, Sep 7, 2011 at 8:52 AM, Eli Friedman <eli.friedman at gmail.com> wrote: > On Tue, Sep 6, 2011 at 11:28 PM, Nikola Smiljanic <popizdeh at gmail.com> > wrote: > > The problem is not in the functions that return multibyte strings (the > > multibyte string is coming from argv) > > argv is implicitly the return from a UTF16->multibyte conversion (i.e. > it's lossy). > > -Eli >...

...k at it and commit (I'm guessing that you don't have commit access)? cfe-commits is in the CC. On Tue, Oct 11, 2011 at 6:55 PM, Aaron Ballman <aaron at aaronballman.com>wrote: > Looks good to me! > > Thanks! > > ~Aaron > > On Tue, Oct 11, 2011 at 2:26 AM, Nikola Smiljanic <popizdeh at gmail.com> > wrote: > > Fixed formatting. > > > > On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at aaronballman.com> > > wrote: > >> > >> I would still fix the code formatting even though you merely > >> uncomm...

Note: /Za shouldn't be used. P.S. I'd say more, but it'd only water down the message. ------------------------------ From: Nikola Smiljanic Sent: 9/30/2011 12:45 AM To: Bryce Cogswell Cc: cfe-dev; llvmdev Subject: Re: [LLVMdev] [cfe-dev] Unicode path handling on Windows I tried to do the conversion to lowercase inside GetFullPath by adding an additional bool parameter to this function. It's not perfect but seems much better than...