llvm dev - Oct 2011 - [LLVMdev] [cfe-dev] Unicode path handling on Windows

Fixed formatting.

On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at
aaronballman.com>wrote:
> I would still fix the code formatting even though you merely
> uncommented it (just to be consistent with the rest of the code).  But
> functionally-speaking, I think your patches are good.
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 15803 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: application/octet-stream
Size: 4685 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111011/25a69eb1/attachment-0001.obj>

Looks good to me!

Thanks!

~Aaron

On Tue, Oct 11, 2011 at 2:26 AM, Nikola Smiljanic <popizdeh at gmail.com>
wrote:
> Fixed formatting.
>
> On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at
aaronballman.com>
> wrote:
>>
>> I would still fix the code formatting even though you merely
>> uncommented it (just to be consistent with the rest of the code).  But
>> functionally-speaking, I think your patches are good.
>>
>> ~Aaron
>

What is the procedure now? Do we just wait for someone else to look at it
and commit (I'm guessing that you don't have commit access)? cfe-commits
is
in the CC.

On Tue, Oct 11, 2011 at 6:55 PM, Aaron Ballman <aaron at
aaronballman.com>wrote:
> Looks good to me!
>
> Thanks!
>
> ~Aaron
>
> On Tue, Oct 11, 2011 at 2:26 AM, Nikola Smiljanic <popizdeh at
gmail.com>
> wrote:
> > Fixed formatting.
> >
> > On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at
aaronballman.com>
> > wrote:
> >>
> >> I would still fix the code formatting even though you merely
> >> uncommented it (just to be consistent with the rest of the code). 
But
> >> functionally-speaking, I think your patches are good.
> >>
> >> ~Aaron
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111012/8a6d54dc/attachment.html>