Joakim Johansson
2011-Sep-14 16:45 UTC
[LLVMdev] [PATCH] Missing include of limits.h on Solaris in PathV2.inc
Hi, Attached is a small patch (based of r139696) which is required for clean builds on Solaris 10 / x86 using gcc 4.5.1 - it is simply a missing include. The exact same problem also exists in the 2.9-stable branch, but not in 2.8. Please consider it for inclusion. Cheers, Joakim -------------- next part -------------- A non-text attachment was scrubbed... Name: solaris_limit.patch Type: application/octet-stream Size: 460 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20110914/fa41d994/attachment.obj> -------------- next part -------------- — Sample failure for 2.9 build which is fixed: llvm[1]: Compiling PathV2.cpp for Debug build In file included from /export/home/jocke/2.9/llvm/lib/Support/PathV2.cpp:770:0: /export/home/jocke/2.9/llvm/lib/Support/Unix/PathV2.inc: In function ‘llvm::error_code llvm::sys::fs::unique_file(const llvm::Twine&, int&, llvm::SmallVectorImpl<char>&)’: /export/home/jocke/2.9/llvm/lib/Support/Unix/PathV2.inc:420:23: error: ‘PATH_MAX’ was not declared in this scope /export/home/jocke/2.9/llvm/lib/Support/Unix/PathV2.inc:421:36: error: ‘real_path_buff’ was not declared in this scope /export/home/jocke/2.9/llvm/lib/Support/Unix/PathV2.inc:429:15: error: ‘real_path_buff’ was not declared in this scope /export/home/jocke/2.9/build/lib/Support/Debug/PathV2.d.tmp: No such file or directory gmake[1]: *** [/export/home/jocke/2.9/build/lib/Support/Debug/PathV2.o] Error 1 gmake[1]: Leaving directory `/export/home/jocke/2.9/build/lib/Support' gmake: *** [all] Error 1
Bill Wendling
2011-Sep-14 21:52 UTC
[LLVMdev] [PATCH] Missing include of limits.h on Solaris in PathV2.inc
On Sep 14, 2011, at 9:45 AM, Joakim Johansson wrote:> Hi, > > Attached is a small patch (based of r139696) which is required for clean builds on Solaris 10 / x86 using gcc 4.5.1 - it is simply a missing include. > > The exact same problem also exists in the 2.9-stable branch, but not in 2.8. > > Please consider it for inclusion. > > Cheers, > > Joakim >Hi Joakim, The patch seemed good, so I applied it. Thanks! In the future, you can send patches to the llvm-commits mailing list. That tends to be the preferred place for patches to go. :-) -bw
Apparently Analagous Threads
- [LLVMdev] [PATCH] compiler-rt patch for clean build on Solaris 10 / x86
- [LLVMdev] [RFC] llvm/include/Support/FileOutputBuffer.h
- [LLVMdev] [cfe-dev] LLVM & Clang file management
- [LLVMdev] [cfe-dev] LLVM & Clang file management
- [LLVMdev] [cfe-dev] LLVM & Clang file management