Hi Matt, After looking at this again I don't think this approach is really tenable. I'm going to start hacking on an alternate approach, which should end up with the same result. Please ping me again if you don't hear anything in a day or two. - Daniel On Mon, Jun 28, 2010 at 12:52 AM, Matt Fleming <matt at console-pimps.org> wrote:> On Tue, Jun 22, 2010 at 12:26:00AM +0100, Matt Fleming wrote: >> Hi Daniel, >> >> attached is a patch that pushes most of the object file specific parsing >> out of AsmParser and down into MachOAsmParser. This was done as a >> cleanup for the ELF work. I know that you're not happy with this >> approach, particularly the fact that as we add more object file formats >> and assembler dialects, it's going to cause a class explosion. But I was >> hoping that we could use this as a foundation for further discussion. >> >> Is there anything else about this patch that you don't like, or anything >> that you think could be done better? What approach would you recommend >> for solving this problem? > > Does anyone have any comments on this? >
On Thu, 1 Jul 2010 13:11:14 -0700, Daniel Dunbar <daniel at zuster.org> wrote:> Hi Matt, > > After looking at this again I don't think this approach is really > tenable. I'm going to start hacking on an alternate approach, which > should end up with the same result. Please ping me again if you don't > hear anything in a day or two.Ping?
Ping = repost to thread if no feedback given below criteria On Jul 11, 2010, at 5:02 AM, Matt Fleming <matt at console-pimps.org> wrote:> On Thu, 1 Jul 2010 13:11:14 -0700, Daniel Dunbar <daniel at zuster.org> wrote: >> Hi Matt, >> >> After looking at this again I don't think this approach is really >> tenable. I'm going to start hacking on an alternate approach, which >> should end up with the same result. Please ping me again if you don't >> hear anything in a day or two. > > Ping? > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Hey Matt, I have a patch sequence which should accomplish the same thing coming in now. There are still some Darwin specific bits left in AsmParser, but most of the stuff is now moved out to an extension class, and I added a basic ELF extension class as well. Please let me know if you see any problems with this approach. - Daniel On Sun, Jul 11, 2010 at 3:02 AM, Matt Fleming <matt at console-pimps.org> wrote:> On Thu, 1 Jul 2010 13:11:14 -0700, Daniel Dunbar <daniel at zuster.org> wrote: >> Hi Matt, >> >> After looking at this again I don't think this approach is really >> tenable. I'm going to start hacking on an alternate approach, which >> should end up with the same result. Please ping me again if you don't >> hear anything in a day or two. > > Ping? > >