similar to: [LLVMdev] Win32 COFF Support - Patch 2

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. 3rd patch

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >  - Please split the patch into at least four parts: >    (1) Add WinCOFFStreamer, with a stub implementation. >    (2) Add WinCOFFObjectWriter, with a stub implementation. >    (3) Fill in WinCOFFStreamer. >    (4) Fill in WinCOFFObjectWriter. Here's the 1'st patch.

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Attached is patch number 4. - Michael Spencer

This probably needs to be slightly tweaked to work with mainline. I don't see anything objectionable, but I think Daniel needs to review this one. Thanks for working on this Michael! -Chris On Jul 3, 2010, at 3:19 AM, Michael Spencer wrote: > On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >> - Please split the patch into at least four parts:

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

Hi Nathan, I'm not quite ready to apply this patch, but I now have time again to work on getting it in. The main reason I am not willing to put it in yet is (a) the size, and (b) the inconsistences with LLVM style. Please fix the following things: - Watch out for case mismatches, i.e., #include "WinCoff.h" when the header is actually WinCOFF.h. - The patch doesn't have a

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp.

On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > write_uint32_le is used to write into a arbitrary data buffer, where as >  WriteLE32 is used to write into the object file. Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I

Hi Michael, Looks great to me, with the caveat that I know nothing about COFF. A few comments: - The term symbol is already very overloaded, I would avoid adding a new 'class Symbol'. - I find it annoying to have more versions of write little endian 32-bit data, but I'm not sure what the right solution is. We can clean this up later, perhaps. - There are a couple of instances of:

write_uint32_le is used to write into a arbitrary data buffer, where as WriteLE32 is used to write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > > > Whats going on with having both write_uint32_le() > > in

Right on, thanks for working on this. I have been busy lately, but its good to see progress being made. On Mon, Jun 21, 2010 at 11:31 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

Hi Michael, Overall patch looks good. I do have a few comments below. My main comment is please try to make the style match that used in the MCMachOStreamer more closely. I intend to refactor more functionality into the base MCObjectStreamer class, and having them use consistent idioms makes this easier; specific instances are included in the comments: -- > diff --git

Hi guys, While trying to get dwarf debugging information to work with Win32 COFF targets, I came across a couple of issues with the current implementation of WinCOFFObjectWriter. Emitting empty section causes debug information to invalid, as the presence of certain debug section implies available information, and emission of labels as symbols confused gdb about the structure of the program. The

I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved.

On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > Hi guys, > While trying to get dwarf debugging information to work with Win32 COFF > targets, I came across a couple of issues with the current implementation > of WinCOFFObjectWriter. Emitting empty section causes debug information to > invalid, as the presence of certain debug section

On Sun, Sep 26, 2010 at 3:28 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > Hi guys, > > While trying to get dwarf debugging information to work with Win32 COFF > > targets, I came across a couple of issues with the current implementation > > of

On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Hi Michael, > > Overall patch looks good. I do have a few comments below. My main > comment is please try to make the style match that used in the > MCMachOStreamer more closely. I intend to refactor more functionality > into the base MCObjectStreamer class, and having them use consistent >

On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > Hi guys, > While trying to get dwarf debugging information to work with Win32 COFF > targets, I came across a couple of issues with the current implementation > of WinCOFFObjectWriter. Emitting empty section causes debug information to > invalid, as the presence of certain debug section

On Tue, Sep 28, 2010 at 7:39 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: >> Hi guys, >> While trying to get dwarf debugging information to work with Win32 COFF >> targets, I came across a couple of issues with the current implementation >>