search for: wincoffstream

...nt is please try to make the style match that used in the MCMachOStreamer more closely. I intend to refactor more functionality into the base MCObjectStreamer class, and having them use consistent idioms makes this easier; specific instances are included in the comments: -- > diff --git a/lib/MC/WinCOFFStreamer.cpp b/lib/MC/WinCOFFStreamer.cpp > index 1030cdb..079a813 100644 > --- a/lib/MC/WinCOFFStreamer.cpp > +++ b/lib/MC/WinCOFFStreamer.cpp > @@ -18,24 +18,41 @@ > #include "llvm/MC/MCSection.h" > #include "llvm/MC/MCSymbol.h" > #include "llvm/MC/MCExpr...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >  - Please split the patch into at least four parts: >    (1) Add WinCOFFStreamer, with a stub implementation. >    (2) Add WinCOFFObjectWriter, with a stub implementation. >    (3) Fill in WinCOFFStreamer. >    (4) Fill in WinCOFFObjectWriter. Here's the 1'st patch. http://github.com/Bigcheese/llvm-mirror/commit/46395d989c7e5e799e9206acceb1174490c92ead And...

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Here's the 2nd patch. http://github.com/Bigcheese/llvm-mirror/commit/b008e685065bef8242bb04cb8b7636cc2610522b And a gi...

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. 3rd patch http://github.com/Bigcheese/llvm-mirror/commit/061848bca977d5d84b296aa91afd9a3a3dac0093 And patch attached. I...

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Attached is patch number 4. - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed......

...getDesc.cpp lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp lib/Target/XCore/MCTargetDesc/XCoreMCTargetDesc.cpp lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp lib/MC/MCELFStreamer.cpp lib/MC/WinCOFFStreamer.cpp lib/MC/MCMachOStreamer.cpp -- Anton -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140311/61c395d6/attachment.html>

...k Daniel needs to review this one. Thanks for working on this Michael! -Chris On Jul 3, 2010, at 3:19 AM, Michael Spencer wrote: > On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >> - Please split the patch into at least four parts: >> (1) Add WinCOFFStreamer, with a stub implementation. >> (2) Add WinCOFFObjectWriter, with a stub implementation. >> (3) Fill in WinCOFFStreamer. >> (4) Fill in WinCOFFObjectWriter. > > 3rd patch > > http://github.com/Bigcheese/llvm-mirror/commit/061848bca977d5d84b296aa91afd9a3a3dac0...

...f "} else". Thanks! - Daniel On Mon, Jul 19, 2010 at 3:09 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >>  - Please split the patch into at least four parts: >>    (1) Add WinCOFFStreamer, with a stub implementation. >>    (2) Add WinCOFFObjectWriter, with a stub implementation. >>    (3) Fill in WinCOFFStreamer. >>    (4) Fill in WinCOFFObjectWriter. > > Attached is patch number 4. > > - Michael Spencer >

On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Hi Michael, > > Overall patch looks good. I do have a few comments below. My main > comment is please try to make the style match that used in the > MCMachOStreamer more closely. I intend to refactor more functionality > into the base MCObjectStreamer class, and having them use consistent >

...an extra newline following 'for' loops, conditionals, or type declarations. - Please see http://llvm.cs.uiuc.edu/docs/CodingStandards.html if you haven't already. There are also some meatier things I would like changed: - Please split the patch into at least four parts: (1) Add WinCOFFStreamer, with a stub implementation. (2) Add WinCOFFObjectWriter, with a stub implementation. (3) Fill in WinCOFFStreamer. (4) Fill in WinCOFFObjectWriter. The first two parts should be trivial, and as small as possible. It is useful to get them in first to make subsequent patches easier t...

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

Hey Rui, > I wonder how llvm-dlltool would fit in the entire picture of mingw > support. I don't think dlltool is the last missing piece. What do you need > to do other than that to fully support mingw using LLVM toolchain? Other then changing `lib/MC/WinCOFFStreamer.cpp` to not use -aligncomm within the EmitCommonSymbol function and a single patch for mingw-w64 itself to pre-populate it's .ctors and .dtors list, so llvm-dlltool is infact the only missing part really. This gives us a fully working clang based mingw-w64 C compiler. C++ and exception handl...

...thout a dumper - just by using the MCAsmStreamer. > > Do you think we should really write a dumper too? > > That's kinda hard and we don't plan to fully support the CodeView format > yet... > > I tried my patch on Chromium and it hit the llvm_unreachable I wrote > in WinCOFFStreamer::EmitCOFFStaticOffset(). > Now that it also supports using a fixup to calculate the offset (that > happens as the second pass, not supported by MCAsmStreamer, right?), I > think I do have to write at least a simple dumper... > > Any hints on how to do that? Should it be a separate...

Hi, I'm embarrassed that I can't figure this out... I have a compiler that outputs my module in either .s assembly format or .obj binary format, either one works just fine. But if I try to output both of them by adding passes, LLVM throws an Assert: void WinCOFFStreamer::EmitLabel(MCSymbol *Symbol) { assert(Symbol->isUndefined() && "Cannot define a symbol twice!"); MCObjectStreamer::EmitLabel(Symbol); } I attached my code which attempts to make it output both... if I comment out the lines for one or the other it works just fine. That co...

...; >>> I wonder how llvm-dlltool would fit in the entire picture of mingw >>> support. I don't think dlltool is the last missing piece. What do you need >>> to do other than that to fully support mingw using LLVM toolchain? >> >> Other then changing `lib/MC/WinCOFFStreamer.cpp` to not use -aligncomm >> within the EmitCommonSymbol function and a single patch for mingw-w64 >> itself to pre-populate it's .ctors and .dtors list, so llvm-dlltool is >> infact the only missing part really. >> > > Also you need to make a change to LLD/COFF...

...writing *some* > tests without a dumper - just by using the MCAsmStreamer. > Do you think we should really write a dumper too? > That's kinda hard and we don't plan to fully support the CodeView format yet... I tried my patch on Chromium and it hit the llvm_unreachable I wrote in WinCOFFStreamer::EmitCOFFStaticOffset(). Now that it also supports using a fixup to calculate the offset (that happens as the second pass, not supported by MCAsmStreamer, right?), I think I do have to write at least a simple dumper... Any hints on how to do that? Should it be a separate app or built into some C...

...-dlltool would fit in the entire picture of mingw >>>>> support. I don't think dlltool is the last missing piece. What do you need >>>>> to do other than that to fully support mingw using LLVM toolchain? >>>> >>>> Other then changing `lib/MC/WinCOFFStreamer.cpp` to not use -aligncomm >>>> within the EmitCommonSymbol function and a single patch for mingw-w64 >>>> itself to pre-populate it's .ctors and .dtors list, so llvm-dlltool is >>>> infact the only missing part really. >>>> >>> >&gt...

...picture of mingw >>>>>>> support. I don't think dlltool is the last missing piece. What do you need >>>>>>> to do other than that to fully support mingw using LLVM toolchain? >>>>>> >>>>>> Other then changing `lib/MC/WinCOFFStreamer.cpp` to not use >>>>>> -aligncomm within the EmitCommonSymbol function and a single patch for >>>>>> mingw-w64 itself to pre-populate it's .ctors and .dtors list, so >>>>>> llvm-dlltool is infact the only missing part really. >>>&...

I am having an issue with MCJIT on the ppc64 machine architecture. The symptom is that for a particular IR function the target machine won't emit neither an object nor an assembly file and subsequent calling the pointer to function results in a segfault. My application generates on the fly several functions with the builder and executes them with the MCJIT engine. I came across this