llvm dev - Dec 2009 - [LLVMdev] [PATCH] Fix recompileAndRelinkFunction

On Tue, Dec 22, 2009 at 6:14 AM, Chris Lattner <clattner at apple.com>
wrote:
> On Dec 19, 2009, at 3:36 PM, Gianluca Guida wrote:
>> Attached patch makes runJITOnFunction more reliable.
>
> When would MCI be null?
Everytime you call recompileAndRelinkFunction. It calls
runJITOnFunction without specifying the MCI argument, which get
defaulted to NULL.

Gianluca


-- 
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra

Please add a test to
http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/JIT/JITTest.cpp?view=markup
verifying that recompileAndRelinkFunction() keeps working. Then this
fix will look fine to me.

On Tue, Dec 22, 2009 at 12:23 AM, Gianluca Guida <glguida at gmail.com>
wrote:
> On Tue, Dec 22, 2009 at 6:14 AM, Chris Lattner <clattner at
apple.com> wrote:
>> On Dec 19, 2009, at 3:36 PM, Gianluca Guida wrote:
>>> Attached patch makes runJITOnFunction more reliable.
>>
>> When would MCI be null?
>
> Everytime you call recompileAndRelinkFunction. It calls
> runJITOnFunction without specifying the MCI argument, which get
> defaulted to NULL.
>
> Gianluca
>
>
> --
> It was a type of people I did not know, I found them very strange and
> they did not inspire confidence at all. Later I learned that I had been
> introduced to electronic engineers.
>                                                  E. W. Dijkstra
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

On Tue, Dec 22, 2009 at 5:51 PM, Jeffrey Yasskin <jyasskin at google.com>
wrote:
> Please add a test to
>
http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/JIT/JITTest.cpp?view=markup
> verifying that recompileAndRelinkFunction() keeps working. Then this
> fix will look fine to me.
Here it is. Unfortunately I'm not exactly a C++ guy so I'm open to
change this code after any comment you might want to have.

Gianluca

-- 
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra
-------------- next part --------------
A non-text attachment was scrubbed...
Name: recompileandrelinktest.patch
Type: application/octet-stream
Size: 1341 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20091222/d215a10a/attachment.obj>