llvm dev - Dec 2009 - [LLVMdev] [PATCH] Fix recompileAndRelinkFunction

Hello,

JIT::recompileAndRelinkFunction's runJITOnFunction does not use the
MCI arg, causing null pointer deferences at every call.

Attached patch makes runJITOnFunction more reliable.

Thanks,
Gianluca

-- 
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-recompileAndRelinkFunction.patch
Type: application/octet-stream
Size: 504 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20091220/1cab323d/attachment.obj>

On Dec 19, 2009, at 3:36 PM, Gianluca Guida wrote:
> Hello,
> 
> JIT::recompileAndRelinkFunction's runJITOnFunction does not use the
> MCI arg, causing null pointer deferences at every call.
> 
> Attached patch makes runJITOnFunction more reliable.
When would MCI be null?

-Chris

On Tue, Dec 22, 2009 at 6:14 AM, Chris Lattner <clattner at apple.com>
wrote:
> On Dec 19, 2009, at 3:36 PM, Gianluca Guida wrote:
>> Attached patch makes runJITOnFunction more reliable.
>
> When would MCI be null?
Everytime you call recompileAndRelinkFunction. It calls
runJITOnFunction without specifying the MCI argument, which get
defaulted to NULL.

Gianluca


-- 
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra