llvm dev - Dec 2009 - [LLVMdev] [PATCH] increase the max number of physical registers

This caused a massive slow down to post-ra scheduler (llc -O3 on x86, -O2 on
ARM). I'm going to revert it for now until it has been addressed.

Evan

On Dec 7, 2009, at 11:39 AM, Dan Gohman wrote:
> 
> On Dec 7, 2009, at 11:15 AM, Pekka Jääskeläinen wrote:
> 
>> Here's the actual patch, sorry ;)
> 
> Applied in r90789.
> 
> Dan
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

On Dec 8, 2009, at 11:33 AM, Evan Cheng wrote:
> This caused a massive slow down to post-ra scheduler (llc -O3 on x86, -O2
on ARM). I'm going to revert it for now until it has been addressed.
Probably caused by this member:

    /// KillIndices - The index of the most recent kill (proceding bottom-up),
    /// or ~0u if the register is not live.
    unsigned KillIndices[TargetRegisterInfo::FirstVirtualRegister];

And this:

  std::fill(KillIndices, array_endof(KillIndices), ~0u);

It should probably be dynamically allocated with TRI->getNumRegs() members
instead.

/jakob

On Dec 8, 2009, at 3:31 PM, Jakob Stoklund Olesen wrote:
> 
> On Dec 8, 2009, at 11:33 AM, Evan Cheng wrote:
> 
>> This caused a massive slow down to post-ra scheduler (llc -O3 on x86,
-O2 on ARM). I'm going to revert it for now until it has been addressed.
> 
> Probably caused by this member:
> 
>    /// KillIndices - The index of the most recent kill (proceding
bottom-up),
>    /// or ~0u if the register is not live.
>    unsigned KillIndices[TargetRegisterInfo::FirstVirtualRegister];
> 
> And this:
> 
>  std::fill(KillIndices, array_endof(KillIndices), ~0u);
> 
> It should probably be dynamically allocated with TRI->getNumRegs()
members instead.
Yep. David Goodwin is going to fix it.

Evan
> 
> /jakob
>