llvm dev - Jul 2009 - [LLVMdev] IMPORTANT: Test Your Changes Before Committing Them!!

The tree has been broken since late last night. This is completely
unacceptable! We have had check-ins which didn't even COMPILE! The
build bots have been complaining all night, but no one has bothered to
look at their messages and figure out whether it was their patches
that caused the problem.

This wastes a huge amount of time trying to figure out what's going
on. In the future, it may result in the tree being rolled back to the
last known good version, losing all of that work in the meantime.

It's been said before, but it bears repeating. It is imperative that
we keep the tree healthy!

-bw

P.S. We are developers and should be developing with assertions on.
That's what the assertions are there for! They aren't there for the
customers.

On Jul 15, 2009, at 11:26 AM, Bill Wendling wrote:
> The tree has been broken since late last night. This is completely
> unacceptable!
Okay, okay, take a deep breath. :)

Yes, it is very very important to keep mainline stable.  We've had an  
impressive and amazing num of improvements going in lately, and  
testing is important.  I think that slowing down a bit today to let  
the tree re-stabilize and the let the build bots keep up is useful.
> We have had check-ins which didn't even COMPILE! The
I'm not sure that this is true.  I believe that the change you're  
referring to would work if you build a release-assert build, which is  
probably what the contributor did.

In any case, please do test your changes before checking them in as  
usual, :)

-Chris

> build bots have been complaining all night, but no one has bothered to
> look at their messages and figure out whether it was their patches
> that caused the problem.
>
> This wastes a huge amount of time trying to figure out what's going
> on. In the future, it may result in the tree being rolled back to the
> last known good version, losing all of that work in the meantime.
>
> It's been said before, but it bears repeating. It is imperative that
> we keep the tree healthy!
>
> -bw
>
> P.S. We are developers and should be developing with assertions on.
> That's what the assertions are there for! They aren't there for the
> customers.
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev