Nicolas Capens
2009-Jun-09 21:58 UTC
[LLVMdev] [Patch] Fix SSE2 packing intrinsics return type
Hi all, Please consider committing the attached patch. I believe the SSE2 packsswb, packssdw and packuswb intrinsics have an incorrect return type. Thanks, Nicolas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090609/85ed0b5e/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: PackSSE2.patch Type: application/octet-stream Size: 1200 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090609/85ed0b5e/attachment.obj>
Eli Friedman
2009-Jun-10 00:56 UTC
[LLVMdev] [Patch] Fix SSE2 packing intrinsics return type
On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> wrote:> Please consider committing the attached patch. I believe the SSE2 packsswb, > packssdw and packuswb intrinsics have an incorrect return type.If we really wanted to do this, an AutoUpgrade patch would be necessary for backwards-compatibility. I'm not sure it's worth bothering. -Eli
Chris Lattner
2009-Jun-10 05:15 UTC
[LLVMdev] [Patch] Fix SSE2 packing intrinsics return type
On Jun 9, 2009, at 5:56 PM, Eli Friedman wrote:> On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> > wrote: >> Please consider committing the attached patch. I believe the SSE2 >> packsswb, >> packssdw and packuswb intrinsics have an incorrect return type. > > If we really wanted to do this, an AutoUpgrade patch would be > necessary for backwards-compatibility. I'm not sure it's worth > bothering.Did they work before with llvm-gcc? If not, then don't worry about backward compatibility. -Chris
Nicolas Capens
2009-Jun-10 12:54 UTC
[LLVMdev] [Patch] Fix SSE2 packing intrinsics return type
Hi Eli, What exactly do mean by an AutoUpgrade patch? I don't see how this could cause any issues with backward compatibility. People currently using these intrinsics need a bitcast of the result to avoid an assert, and with the patch applied the bitcast is no longer necessary. Cheers, Nicolas -----Original Message----- From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Eli Friedman Sent: woensdag 10 juni 2009 2:57 To: LLVM Developers Mailing List Subject: Re: [LLVMdev] [Patch] Fix SSE2 packing intrinsics return type On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> wrote:> Please consider committing the attached patch. I believe the SSE2packsswb,> packssdw and packuswb intrinsics have an incorrect return type.If we really wanted to do this, an AutoUpgrade patch would be necessary for backwards-compatibility. I'm not sure it's worth bothering. -Eli _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev