search for: packuswb

Hi all, Please consider committing the attached patch. I believe the SSE2 packsswb, packssdw and packuswb intrinsics have an incorrect return type. Thanks, Nicolas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090609/85ed0b5e/attachment.html> -------------- next part -------------- A non-text attach...

On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> wrote: > Please consider committing the attached patch. I believe the SSE2 packsswb, > packssdw and packuswb intrinsics have an incorrect return type. If we really wanted to do this, an AutoUpgrade patch would be necessary for backwards-compatibility. I'm not sure it's worth bothering. -Eli

On Jun 9, 2009, at 5:56 PM, Eli Friedman wrote: > On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> > wrote: >> Please consider committing the attached patch. I believe the SSE2 >> packsswb, >> packssdw and packuswb intrinsics have an incorrect return type. > > If we really wanted to do this, an AutoUpgrade patch would be > necessary for backwards-compatibility. I'm not sure it's worth > bothering. Did they work before with llvm-gcc? If not, then don't worry about backward compatib...

...ddw %%mm7,%%mm5\n" /* (_pix[_ystride]+f); */ +"movq %%mm1,%%mm2\n" +"punpcklbw %%mm0,%%mm1\n" +"punpckhbw %%mm0,%%mm2\n" //[ystride*2] +"psubw %%mm6,%%mm1\n" /* (_pix[_ystride*2]-f); */ +"psubw %%mm7,%%mm2\n" /* (_pix[_ystride*2]-f); */ +"packuswb %%mm2,%%mm1\n" +"packuswb %%mm5,%%mm4\n" +"movq %%mm1,(%0,%1,2)\n" /* _pix[_ystride*2]= */ +"movq %%mm4,(%0,%1)\n" /* _pix[_ystride]= */ +"emms\n" +: +: "r" (_pix), "r" (_ystride), "r" (_bv) +: "esi", "edi&qu...

...put values */ +" decl %%ecx \n\t" /* dec counter */ +" paddsw %%mm3, %%mm1 \n\t" /* add+128 and saturate to 16bit */ +" lea 0x10(%1), %1 \n\t" /*_residuo+16 */ +" paddsw %%mm2, %%mm0 \n\t" /* add+128 and saturate to 16bit */ +" packuswb %%mm1, %%mm0 \n\t" /* pack saturate with next(high) four values */ +" movq %%mm0, (%0) \n\t" /* writeback */ +" lea (%0,%2), %0 \n\t" /*_dst+_dst_ystride */ +" jns 1b \n\t" /* loop */ + : "+r" (_dst) + : "r" (_residue),...

...ni 2009 2:57 To: LLVM Developers Mailing List Subject: Re: [LLVMdev] [Patch] Fix SSE2 packing intrinsics return type On Tue, Jun 9, 2009 at 2:58 PM, Nicolas Capens<nicolas at capens.net> wrote: > Please consider committing the attached patch. I believe the SSE2 packsswb, > packssdw and packuswb intrinsics have an incorrect return type. If we really wanted to do this, an AutoUpgrade patch would be necessary for backwards-compatibility. I'm not sure it's worth bothering. -Eli _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu...

...put values */ +" decl %%ecx \n\t" /* dec counter */ +" paddsw %%mm3, %%mm1 \n\t" /* add+128 and saturate to 16bit */ +" lea 0x10(%1), %1 \n\t" /*_residuo+16 */ +" paddsw %%mm2, %%mm0 \n\t" /* add+128 and saturate to 16bit */ +" packuswb %%mm1, %%mm0 \n\t" /* pack saturate with next(high) four values */ +" movq %%mm0, (%0) \n\t" /* writeback */ +" lea (%0,%2), %0 \n\t" /*_dst+_dst_ystride */ +" jns 1b \n\t" /* loop */ + : "+r" (_dst) + : "r" (_residue),...

quite some speed improvement indeed. attached the updated patch to apply to svn/trunk. j -------------- next part -------------- A non-text attachment was scrubbed... Name: theora-mmx.patch.gz Type: application/x-gzip Size: 8648 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora-dev/attachments/20040824/5a5f2731/theora-mmx.patch-0001.bin