llvm dev - Jan 2009 - [LLVMdev] cygwin build patch

LLVM doesn't build out of the box on Cygwin, because Cygwin defines
uint32_t as "unsigned long" rather than "unsigned int".

The attached patch allows me to build head of svn (rev 62510) on
Cygwin using GCC 4. Can this be committed please?

I realise that the DataTypes.h.in part might be controversial. Also,
there's probably a better place to put it, but I'm not sure where.

Thanks,
Jay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cygwin.patch
Type: application/octet-stream
Size: 2939 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090119/7c7e21b7/attachment.obj>

On Jan 19, 2009, at 7:44 AM, Jay Foad wrote:
> LLVM doesn't build out of the box on Cygwin, because Cygwin defines
> uint32_t as "unsigned long" rather than "unsigned int".
>
> The attached patch allows me to build head of svn (rev 62510) on
> Cygwin using GCC 4. Can this be committed please?
Thanks applied:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090119/072367.html
> I realise that the DataTypes.h.in part might be controversial. Also,
> there's probably a better place to put it, but I'm not sure where.
I didn't apply this part.  What problems does it cause to not have  
this?  Can we fix uses of max and min?

-Chris

>> I realise that the DataTypes.h.in part might be controversial. Also,
>> there's probably a better place to put it, but I'm not sure
where.
>
> I didn't apply this part.  What problems does it cause to not have
> this?  Can we fix uses of max and min?
I get these errors in lib:

.../lib/Analysis/ValueTracking.cpp:162: error: no matching function
for call to 'min(unsigned int&, uint32_t&)'
.../lib/Analysis/ValueTracking.cpp:163: error: no matching function
for call to 'min(unsigned int&, uint32_t&)'
.../lib/Analysis/ValueTracking.cpp:358: error: no matching function
for call to 'min(unsigned int&, uint32_t)'
.../lib/Analysis/ValueTracking.cpp:469: error: no matching function
for call to 'min(unsigned int&, long unsigned int)'
.../lib/Analysis/ValueTracking.cpp:708: error: no matching function
for call to 'min(unsigned int&, uint32_t)'
.../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1432: error: no matching
function for call to 'max(long unsigned int, unsigned int&)'
.../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1747: error: no matching
function for call to 'min(unsigned int&, uint32_t)'
.../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2033: error: no matching
function for call to 'min(unsigned int&, uint32_t)'

I could try to fix this by changing the code to consistently use
either unsigned or uint32_t (which?), rather than both. Or by adding
casts at the point of calling min/max. What would you prefer?

Thanks,
Jay.