> This is my patch for MSVC 2008 and it was applied by Chris: > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062390.html > > I tested it and it is ok for the 2.3 release.I don't believe I can apply this patch. There have been several patches applied recently to TOT to allow MSVC 2005 which I think many people are using. Does this patch mean that one can only use MSVC 2008? -Tanya> > Razvan > > ----- Original Message ----- > From: "Tanya Lattner" <tonic at nondot.org> > To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> > Sent: Tuesday, May 20, 2008 7:40 AM > Subject: Re: [LLVMdev] 2.3 Pre-release available for testing > > >> >> On May 19, 2008, at 9:13 PM, Razvan Aciu wrote: >> >>> I tested this pre-release on MSVC and I noted that none of the >>> submitted >>> patches (mine or others) were applied. >>> So the llvm 2.3 will not compile out of the box in MSVC? >>> >> >> Please provide me with a link to the patch(s) that need to be applied >> (llvm-commits archive email). I only apply patches that have been >> sent to me and approved by the various llvm code owners. >> >> -Tanya >> >>> Razvan >>> >>> >>> ----- Original Message ----- >>> From: "Tanya M. Lattner" <tonic at nondot.org> >>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>> Sent: Monday, May 19, 2008 9:00 PM >>> Subject: [LLVMdev] 2.3 Pre-release available for testing >>> >>> >>>> >>>> Just a reminder, please complete your testing by May 21st! >>>> >>>> Thanks, >>>> Tanya >>>> >>>> ---------- Forwarded message ---------- >>>> Date: Tue, 13 May 2008 00:25:41 -0700 >>>> From: Tanya Lattner <tonic at nondot.org> >>>> To: LLVM Developers Mailing List <llvmdev at cs.uiuc.edu> >>>> Subject: 2.3 Pre-release available for testing >>>> >>>> LLVMers, >>>> >>>> The 2.3 pre-release is available for testing: >>>> http://llvm.org/prereleases/2.3/ >>>> >>>> If you have time, I'd appreciate anyone who can help test the >>>> release. >>>> Please >>>> do the following: >>>> >>>> 1) Download/compile llvm source, and either compile llvm-gcc >>>> source or use >>>> llvm-gcc binary. >>>> 2) Run make check, send me the testrun.log >>>> 3) Run "make TEST=nightly report" and send me the report.nightly.txt >>>> 4) Please provide details on what platform you compiled LLVM on >>>> and how >>>> you >>>> built LLMV (src == obj, or src != obj) >>>> >>>> Right now, I am aware of several regression on Linux (x86) and >>>> Darwin (x86 >>>> and >>>> ppc). I'll be filing bugs for these shortly and the patches will be >>>> incorporated into the release branch. >>>> >>>> Please COMPLETE ALL TESTING BY end of the day on May 21st! >>>> >>>> Thanks, >>>> Tanya Lattner >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >
As I saw from the mailing list the MSVC 2005 patches were made to take into account the new files from the development branch, files which are not in the 2.3 release. So for now the below patch is the only one functional for the release. If I am wrong, please someone correct me. If someone can make a 2005 patch for the release branch, it is ok. Else, I am afraid that this one is for now the only functional one, with the drawback that it is made for MSVC 2008. If there will be no other patches, the alternative is that the 2.3 release will not work with any MSVC. Anyway, it is not so hard to sync the MSVC projects with the 2.3 release files and if someone with MSVC 2005 can do it, please do it. Razvan ----- Original Message ----- From: "Tanya M. Lattner" <tonic at nondot.org> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> Sent: Tuesday, May 20, 2008 7:49 PM Subject: Re: [LLVMdev] 2.3 Pre-release available for testing> >> This is my patch for MSVC 2008 and it was applied by Chris: >> >> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062390.html >> >> I tested it and it is ok for the 2.3 release. > > I don't believe I can apply this patch. There have been several patches > applied recently to TOT to allow MSVC 2005 which I think many people are > using. Does this patch mean that one can only use MSVC 2008? > > -Tanya > >> >> Razvan >> >> ----- Original Message ----- >> From: "Tanya Lattner" <tonic at nondot.org> >> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >> Sent: Tuesday, May 20, 2008 7:40 AM >> Subject: Re: [LLVMdev] 2.3 Pre-release available for testing >> >> >>> >>> On May 19, 2008, at 9:13 PM, Razvan Aciu wrote: >>> >>>> I tested this pre-release on MSVC and I noted that none of the >>>> submitted >>>> patches (mine or others) were applied. >>>> So the llvm 2.3 will not compile out of the box in MSVC? >>>> >>> >>> Please provide me with a link to the patch(s) that need to be applied >>> (llvm-commits archive email). I only apply patches that have been >>> sent to me and approved by the various llvm code owners. >>> >>> -Tanya >>> >>>> Razvan >>>> >>>> >>>> ----- Original Message ----- >>>> From: "Tanya M. Lattner" <tonic at nondot.org> >>>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu> >>>> Sent: Monday, May 19, 2008 9:00 PM >>>> Subject: [LLVMdev] 2.3 Pre-release available for testing >>>> >>>> >>>>> >>>>> Just a reminder, please complete your testing by May 21st! >>>>> >>>>> Thanks, >>>>> Tanya >>>>> >>>>> ---------- Forwarded message ---------- >>>>> Date: Tue, 13 May 2008 00:25:41 -0700 >>>>> From: Tanya Lattner <tonic at nondot.org> >>>>> To: LLVM Developers Mailing List <llvmdev at cs.uiuc.edu> >>>>> Subject: 2.3 Pre-release available for testing >>>>> >>>>> LLVMers, >>>>> >>>>> The 2.3 pre-release is available for testing: >>>>> http://llvm.org/prereleases/2.3/ >>>>> >>>>> If you have time, I'd appreciate anyone who can help test the >>>>> release. >>>>> Please >>>>> do the following: >>>>> >>>>> 1) Download/compile llvm source, and either compile llvm-gcc >>>>> source or use >>>>> llvm-gcc binary. >>>>> 2) Run make check, send me the testrun.log >>>>> 3) Run "make TEST=nightly report" and send me the report.nightly.txt >>>>> 4) Please provide details on what platform you compiled LLVM on >>>>> and how >>>>> you >>>>> built LLMV (src == obj, or src != obj) >>>>> >>>>> Right now, I am aware of several regression on Linux (x86) and >>>>> Darwin (x86 >>>>> and >>>>> ppc). I'll be filing bugs for these shortly and the patches will be >>>>> incorporated into the release branch. >>>>> >>>>> Please COMPLETE ALL TESTING BY end of the day on May 21st! >>>>> >>>>> Thanks, >>>>> Tanya Lattner >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >> > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Razvan Aciu wrote:> As I saw from the mailing list the MSVC 2005 patches were made to take into > account the new files from the development branch, files which are not in > the 2.3 release. So for now the below patch is the only one functional for > the release. If I am wrong, please someone correct me. > > If someone can make a 2005 patch for the release branch, it is ok. Else, I > am afraid that this one is for now the only functional one, with the > drawback that it is made for MSVC 2008. If there will be no other patches, > the alternative is that the 2.3 release will not work with any MSVC. > Anyway, it is not so hard to sync the MSVC projects with the 2.3 release > files and if someone with MSVC 2005 can do it, please do it.Ok, I got the release_23 branch and added/removed files until it would build without errors. I didn't have time to test the clang build, but at least this patch will make things compile so someone else can test it. m. PS. Visual Studio really hates how the operator new is overridden in User.h:42, you get thousands upon thousands of warnings of the form: warning C4291: 'void *llvm::User::operator new(size_t,size_t)' : no matching operator delete found; memory will not be freed if initialization throws an exception There's also quite a few other things you get warnings about, mixed use of struct/class for the same thing and conversions from 64 bit to 32 bit that are potentially unsafe. Also constantfolding.cpp has two functions that don't return a value (but have assert(0 && ...) at the end) at line 622 and 605 without calling abort() -- Visual Studio give warnings about other places that _do_ call abort() as well, but I guess that's fine. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: release_23_vs2005.patch URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080521/f625eef4/attachment.ksh>
> As I saw from the mailing list the MSVC 2005 patches were made to take into > account the new files from the development branch, files which are not in > the 2.3 release. So for now the below patch is the only one functional for > the release. If I am wrong, please someone correct me.Yes, but what I want to do is merge the patches from mainline for MSVC 2005 to the release branch. The goal is that I want you to be able to build using 2008 and for everyone using 2005 to be able to build as well. I am sorry if I gave the impression that I did not care about building LLVM with MSVC for 2.3. That is not the case at all. I should have worded my reply differently. What I was hoping for was that someone could go through the patches and verify that if applied to the release23 branch that it would build for 2005 and 2008. I do not have MSVC to be able to test it myself. These are the patches that I think we need: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062421.html http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080512/062599.html http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080519/062673.html Can someone on MSVC 2005 and someone on 2008 please checkout the release_23 branch and apply these ptaches? Let me know if thats enough to get things building for MSVC 2005 and 2008. Thanks, -Tanya