llvm dev - Aug 2007 - [LLVMdev] Suspicious code for X86 target

Hi,

I found some suspicious code in 
X86TargetLowering::getRegClassForInlineAsmConstraint, but I don't know if 
it's a bug or my poor understanding of what the code does.

This is the code in question:
(lib/Target/X86/X86ISelLowering.cpp:5064)

 if (VT == MVT::i32)
   return make_vector<unsigned>(X86::EAX, X86::EDX, X86::ECX, X86::EBX,
0);
 else if (VT == MVT::i16)
   return make_vector<unsigned>(X86::AX, X86::DX, X86::CX, X86::BX, 0);
 else if (VT == MVT::i8)
   return make_vector<unsigned>(X86::AL, X86::DL, X86::CL, X86::DL, 0);

In the last vector, I would expect the last DL to be BL instead.

Bye,
		Maarten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20070814/632e17d4/attachment.sig>

Yes, it's a typo. I'll fix. Thanks!

Evan
On Aug 13, 2007, at 3:44 PM, Maarten ter Huurne wrote:
> Hi,
>
> I found some suspicious code in
> X86TargetLowering::getRegClassForInlineAsmConstraint, but I don't  
> know if
> it's a bug or my poor understanding of what the code does.
>
> This is the code in question:
> (lib/Target/X86/X86ISelLowering.cpp:5064)
>
> if (VT == MVT::i32)
>   return make_vector<unsigned>(X86::EAX, X86::EDX, X86::ECX,  
> X86::EBX, 0);
> else if (VT == MVT::i16)
>   return make_vector<unsigned>(X86::AX, X86::DX, X86::CX, X86::BX,
0);
> else if (VT == MVT::i8)
>   return make_vector<unsigned>(X86::AL, X86::DL, X86::CL, X86::DL,
0);
>
> In the last vector, I would expect the last DL to be BL instead.
>
> Bye,
> 		Maarten
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev