Linux Virtualization - Mar 2023 - [PATCH v2 1/2] vdpa/mlx5: Extend driver support for new features

On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com>
wrote:
>
>
>
> > From: Eli Cohen <elic at nvidia.com>
> > Sent: Wednesday, March 15, 2023 3:28 AM
> >
> > Extend the possible list for features that can be supported by
firmware.
> > Note that different versions of firmware may or may not support these
> > features. The driver is made aware of them by querying the firmware.
> >
> > While doing this, improve the code so we use enum names instead of
hard
> > coded numerical values.
> >
> > The new features supported by the driver are the following:
> >
> > VIRTIO_NET_F_MRG_RXBUF
> > VIRTIO_NET_F_HOST_UFO
> UFO is deprecated in Linux kernel, there are no known user either and we do
not plan to support it.
Note that there's an emulation code for preserving migration
compatibility in the kernel.
> Please remove this entry along with below GUEST_UFO.
If there's no plan for supporting migration from existing software
backends, we can remove this.

Thanks
>
> > VIRTIO_NET_F_HOST_ECN
> > VIRTIO_NET_F_GUEST_UFO
> > VIRTIO_NET_F_GUEST_ECN
> > VIRTIO_NET_F_GUEST_TSO6
> > VIRTIO_NET_F_GUEST_TSO4
>

On 3/19/2023 11:44 PM, Jason Wang wrote:
> On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com>
wrote:
>>
>>
>>> From: Eli Cohen <elic at nvidia.com>
>>> Sent: Wednesday, March 15, 2023 3:28 AM
>>>
>>> Extend the possible list for features that can be supported by
firmware.
>>> Note that different versions of firmware may or may not support
these
>>> features. The driver is made aware of them by querying the
firmware.
>>>
>>> While doing this, improve the code so we use enum names instead of
hard
>>> coded numerical values.
>>>
>>> The new features supported by the driver are the following:
>>>
>>> VIRTIO_NET_F_MRG_RXBUF
>>> VIRTIO_NET_F_HOST_UFO
>> UFO is deprecated in Linux kernel, there are no known user either and
we do not plan to support it.
> Note that there's an emulation code for preserving migration
> compatibility in the kernel.
I wonder if there's a command line option to prohibit QEMU from saving 
this host capability to the migration stream? If not I think it's a 
nightmare every vendor has to support already-deprecated UFO in their 
h/w device.

Thanks,
-Siwei
>
>> Please remove this entry along with below GUEST_UFO.
> If there's no plan for supporting migration from existing software
> backends, we can remove this.
>
> Thanks
>
>>> VIRTIO_NET_F_HOST_ECN
>>> VIRTIO_NET_F_GUEST_UFO
>>> VIRTIO_NET_F_GUEST_ECN
>>> VIRTIO_NET_F_GUEST_TSO6
>>> VIRTIO_NET_F_GUEST_TSO4