search for: elic

On Sun, Jan 15, 2023 at 7:08 PM Eli Cohen <elic at nvidia.com> wrote: > > > From: Jason Wang <jasowang at redhat.com> > > Sent: Wednesday, 11 January 2023 8:28 > > To: mst at redhat.com; jasowang at redhat.com > > Cc: Eli Cohen <elic at nvidia.com>; gdawar at amd.com; > > virtualization at lists.li...

...t was unmapped from the MTT: mlx5_core 0000:41:04.2: mlx5_cmd_out_err:782:(pid 8321): CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status bad parameter(0x3), syndrome (0x5fa1c), err(-22) Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") Cc: Eli Cohen <elic at nvidia.com> Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> Reviewed-by: Eli Cohen <elic at nvidia.com> --- v3: move suspended to struct mlx5_vdpa_dev v2: removed the change for improving warning message --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + drivers/vdpa/mlx5/net/ml...

...> mlx5_core 0000:41:04.2: mlx5_cmd_out_err:782:(pid 8321): > CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status > bad parameter(0x3), syndrome (0x5fa1c), err(-22) > > Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") > Cc: Eli Cohen <elic at nvidia.com> > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Eli Cohen <elic at nvidia.com> > > --- > v3: move suspended to struct mlx5_vdpa_dev > v2: removed the change for improving warning message > --- > drivers/vdpa/mlx5/core/mlx5...

...:41:04.2: mlx5_cmd_out_err:782:(pid 8321): >> CREATE_GENERAL_OBJECT(0xa00) op_mod(0xd) failed, status >> bad parameter(0x3), syndrome (0x5fa1c), err(-22) >> >> Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") >> Cc: Eli Cohen <elic at nvidia.com> >> Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> >> Reviewed-by: Eli Cohen <elic at nvidia.com> >> >> --- >> v3: move suspended to struct mlx5_vdpa_dev >> v2: removed the change for improving warning message >> --- >&...

On Sun, Aug 09, 2020 at 06:34:04AM +0000, Eli Cohen wrote: > Acked-by: Eli Cohen <elic at nvidia.com> > > BTW, vdpa_sim has the same bug. > I sent a patch for that on April 6. [PATCH 2/2] vdpa: Fix pointer math bug in vdpasim_get_config() Jason acked the patch but it wasn't applied. regards, dan carpenter

On Sun, Mar 12, 2023 at 4:41?PM Eli Cohen <elic at nvidia.com> wrote: > > When deleting the vdpa device, the debugfs files need to be removed so > need to remove debugfs after the device has been unregistered. > > This fixes null pointer dereference when someone deletes the device > after debugfs has been populated. > &gt...

On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com> wrote: > > > > > From: Eli Cohen <elic at nvidia.com> > > Sent: Wednesday, March 15, 2023 3:28 AM > > > > Extend the possible list for features that can be supported by firmware. > > Note that different versions of firmware may or may not support these > > features. The driver is made aware of them by qu...

On Mon, Apr 3, 2023 at 2:47?PM Eli Cohen <elic at nvidia.com> wrote: > > > On 03/04/2023 8:01, Jason Wang wrote: > > On Sun, Apr 2, 2023 at 10:15?PM Eli Cohen <elic at nvidia.com> wrote: > >> Current code ignores link state updates if VIRTIO_NET_F_STATUS was not > >> negotiated. However, link state upda...

...s ioctls: > > 1) the ioctls was blindly added to vring ioctl instead of vdpa device > ioctl > 2) vhost_set_backend_features() was called when dev mutex has already > been held which will lead a deadlock > > This patch fixes the above issues. > > Cc: Eli Cohen <elic at nvidia.com> > Reported-by: Zhu Lingshan <lingshan.zhu at intel.com> > Fixes: 653055b9acd4 ("vhost-vdpa: support get/set backend features") > Signed-off-by: Jason Wang <jasowang at redhat.com> Don't we want the fixes queued right now, as opposed to the rest...

...hen creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > > Acked-by: Jason Wang <jasowang at redhat.com> > Signed-off-by: Eli Cohen <elic at nvidia.com> I have a question. Could you guys try with the recent XDP mergeable buffer rework? Does this address the performance issue you are observing? Specifically: Message-Id: <20230322025701.2955-1-xuanzhuo at linux.alibaba.com> Message-Id: <20230322030308.16046-1-xuanzhuo a...

On Wed, Mar 15, 2023 at 3:28?PM Eli Cohen <elic at nvidia.com> wrote: > > Extend the possible list for features that can be supported by firmware. > Note that different versions of firmware may or may not support these > features. The driver is made aware of them by querying the firmware. > > While doing this, improve the co...

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

...gt; > > > > > > > For example: > > > > > > > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 > > > > > > > device_features 0x300cb982b > > > > > > > > > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > > > What's the reason to turn it off by default? It's generally a > > > > > > performance win isn't it? > > > > > It has negative impact on packet rate so we want to keep it off by default. > > > >...

On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > Change core vdpa functionality into a loadbale module such that upcoming > block implementation will be able to use it. > > Signed-off-by: Eli Cohen <elic at nvidia.com> Why don't we merge this patch together with the block module? > --- > V0 --> V1: > Removed "default n" for configu options as 'n' is the default > > drivers/vdpa/Kconfig | 8 +++----- > drivers/vdpa/Makefile...

...hael S. Tsirkin wrote: > > On Thu, Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > > > Change core vdpa functionality into a loadbale module such that upcoming > > > block implementation will be able to use it. > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > Why don't we merge this patch together with the block module? > > > > Since there are still not too many users of this driver, I would prefer > to merge this as early as possible so pepole get used to the involved > modules. > >...

...Sep 24, 2020 at 05:32:31PM +0300, Eli Cohen wrote: > > > > > Change core vdpa functionality into a loadbale module such that upcoming > > > > > block implementation will be able to use it. > > > > > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > > > > > Why don't we merge this patch together with the block module? > > > > > > > > > > Since there are still not too many users of this driver, I would prefer > > > to merge this as early as possible...

...ohen wrote: > > > > > > > Change core vdpa functionality into a loadbale module such that upcoming > > > > > > > block implementation will be able to use it. > > > > > > > > > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > > > > > > > > > > > Why don't we merge this patch together with the block module? > > > > > > > > > > > > > > > > Since there are still not too many users of this driver, I would prefer...

...;) introduces two malfunction backend features ioctls: 1) the ioctls was blindly added to vring ioctl instead of vdpa device ioctl 2) vhost_set_backend_features() was called when dev mutex has already been held which will lead a deadlock This patch fixes the above issues. Cc: Eli Cohen <elic at nvidia.com> Reported-by: Zhu Lingshan <lingshan.zhu at intel.com> Fixes: 653055b9acd4 ("vhost-vdpa: support get/set backend features") Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vdpa.c | 30 ++++++++++++++++-------------- 1 file changed, 16 ins...

..._CONFIG_S_DRIVER_OK, don't attempt to create resources because it > may fail. For example, if the VQ is not ready there is no point in > creating resources. > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > Signed-off-by: Eli Cohen <elic at nvidia.com> > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 9df69d5efe8c..c89cd48a0aab 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet...

..._CONFIG_S_DRIVER_OK, don't attempt to create resources because it > may fail. For example, if the VQ is not ready there is no point in > creating resources. > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > Signed-off-by: Eli Cohen <elic at nvidia.com> Could you add a bit more data about the problem to the log? To be more exact, what exactly happens right now? > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/...