search for: parav

virtnet_rq_free_unused_buf() helper function to free the buffer already exists. Avoid code duplication by reusing existing function. Signed-off-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index d45e140b6852..c1faaf11fbcd 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1...

On Fri, Jan 13, 2023 at 3:37 PM Parav Pandit <parav at nvidia.com> wrote: > > > > From: Alexander H Duyck <alexander.duyck at gmail.com> > > Sent: Friday, January 13, 2023 6:24 PM > > > > On Sat, 2023-01-14 at 00:36 +0200, Parav Pandit wrote: > > > A smallest Ethernet frame defined by...

Hi, These two changes improve the small packet handling. Patch summary: patch-1 fixes the length check by considering Ethernet 60B frame size patch-2 avoids code duplication by reuses existing buffer free helper Please review. Parav Pandit (2): virtio_net: Fix short frame length check virtio_net: Reuse buffer free function drivers/net/virtio_net.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.26.2

> From: Alex Williamson > Sent: Wednesday, September 18, 2019 1:31 AM > > [cc +Parav] > > On Thu, 12 Sep 2019 17:40:10 +0800 > Jason Wang <jasowang at redhat.com> wrote: > > > Hi all: > > > > During the development of virtio-mdev[1]. I find that mdev needs to be > > extended to support devices other than vfio mdev device. So this > &gt...

...callback. This improves the code auditing and also ensure that xdp rxq info is not unregistered while NAPI on RXQ is ongoing. Please review. Patch summary: patch-1 ensures that xdp rq info is unregistered after rq napi is disabled patch-2 keeps the mirror sequence for close() be mirror of open() Parav Pandit (2): virtio-net: Keep stop() to follow mirror sequence of open() virtio-net: Maintain reverse cleanup order drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.26.2

is_power_of_2() already performs the zero check. Hence avoid duplicate check. While at it, move the query of size check also adjacent to where its used for the disabled vq. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Gavin Li <gavinl at nvidia.com> Reviewed-by: Bodong Wang <bodong at nvidia.com> --- drivers/virtio/virtio_pci_modern.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/vi...

...fo while RQ NAPI is still enabled and packet processing may be ongoing. Follow the mirror sequence of open() in the stop() callback. This ensures that when rxq info is unregistered, no rx packet processing is ongoing. Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 7e1a98430190..b7d0b54c3bb0 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2279,8 +...

On 2019/11/2 ??4:11, Parav Pandit wrote: > >> -----Original Message----- >> From: Jason Wang <jasowang at redhat.com> >> Sent: Wednesday, October 30, 2019 1:45 AM >> To: kvm at vger.kernel.org; linux-s390 at vger.kernel.org; linux- >> kernel at vger.kernel.org; dri-devel at lists.freede...

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang <jasowang at redhat.com> wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of

On Wed, 16 Oct 2019 15:31:25 +0000 Parav Pandit <parav at mellanox.com> wrote: > > -----Original Message----- > > From: Cornelia Huck <cohuck at redhat.com> > > Sent: Wednesday, October 16, 2019 3:53 AM > > To: Parav Pandit <parav at mellanox.com> > > Cc: Alex Williamson <alex.williamson...

...of disable queue pairs, and use newly introduced helper function in error unwinding and virtnet_close; Issue: 3383038 Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> Reviewed-by: Simon Horman <simon.horman at corigine.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> Change-Id: Ib4c6a97cb7b837cfa484c593dd43a435c47ea68f --- drivers/net/virtio_net.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 inserti...

...gned for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of callback to be used by > vfio-mdev and virtio-mdev. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > .../driver-api/vfio-mediated-device.rst | 35 +++++++++---- > MAINTAINERS | 1 + > drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++...

...gned for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of callback to be used by > vfio-mdev and virtio-mdev. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > .../driver-api/vfio-mediated-device.rst | 35 +++++++++---- > MAINTAINERS | 1 + > drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++...

On Wed, 16 Oct 2019 20:48:06 +0000 Parav Pandit <parav at mellanox.com> wrote: > > From: Alex Williamson <alex.williamson at redhat.com> > > On Wed, 16 Oct 2019 15:31:25 +0000 > > Parav Pandit <parav at mellanox.com> wrote: > > > > From: Cornelia Huck <cohuck at redhat.com> > >...

...t 11:57?AM Feng Liu <feliu at nvidia.com> wrote: > > Add const to make the read-only pointer parameters clear, similar to > many existing functions. > > Signed-off-by: Feng Liu <feliu at nvidia.com> > Reviewed-by: Jiri Pirko <jiri at nvidia.com> > Reviewed-by: Parav Pandit <parav at nvidia.com> > Reviewed-by: Gavin Li <gavinl at nvidia.com> > Reviewed-by: Bodong Wang <bodong at nvidia.com> > --- > drivers/virtio/virtio_ring.c | 25 ++++++++++++------------- > include/linux/virtio.h | 12 ++++++------ > 2 files changed...

On 2023-03-10 a.m.8:36, Parav Pandit wrote: > > >> From: Feng Liu <feliu at nvidia.com> >> Sent: Friday, March 10, 2023 12:34 AM > >> >> - if (!is_power_of_2(num)) { >> - dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", >> num); >> - return ER...

On Fri, Mar 17, 2023 at 9:58?PM Parav Pandit <parav at mellanox.com> wrote: > > > > > From: Eli Cohen <elic at nvidia.com> > > Sent: Wednesday, March 15, 2023 3:28 AM > > > > Extend the possible list for features that can be supported by firmware. > > Note that different versions of fi...

...at 06:43:46PM -0400, Feng Liu wrote: >> Use newly introduced helper function that exactly does the same of >> closing the queue pairs. >> >> Signed-off-by: Feng Liu <feliu at nvidia.com> >> Reviewed-by: William Tu <witu at nvidia.com> >> Reviewed-by: Parav Pandit <parav at nvidia.com> > > I guess this was put in a separate patch to 1/2, as it's more > net-next material, as opposed to 1/2 which seems to be net material. > FWIIW, I'd lean to putting 1/2 in net. And holding this one for net-next. > > That aside, this lo...

Use newly introduced helper function that exactly does the same of closing the queue pairs. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: William Tu <witu at nvidia.com> Reviewed-by: Parav Pandit <parav at nvidia.com> --- drivers/net/virtio_net.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index fc6ee833a09f..5cd78e154d14 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2...