Linux Virtualization - Sep 2020 - [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

On Thu, Sep 24, 2020 at 01:24:13PM +0300, Eli Cohen
wrote:
> On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
> > > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > > > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > > > @@ -31,7 +31,7 @@ config IFCVF
> > > >
> > > >  config MLX5_VDPA
> > > >  	bool "MLX5 VDPA support library for ConnectX
devices"
> > > > -	depends on MLX5_CORE
> > > > +	depends on VHOST_IOTLB && MLX5_CORE
> > > >  	default n
> > > 
> > > While we are here, can anyone who apply this patch delete the
"default n" line?
> > > It is by default "n".
> 
> I can do that
> 
> > > 
> > > Thanks
> > 
> > Hmm other drivers select VHOST_IOTLB, why not do the same?
> 
> I can't see another driver doing that.
Well grep VHOST_IOTLB and you will see some examples.
> Perhaps I can set dependency on
> VHOST which by itself depends on VHOST_IOTLB?
VHOST is processing virtio in the kernel. You don't really need that
for mlx, do you?
> > 
> > 
> > > >  	help
> > > >  	  Support library for Mellanox VDPA drivers. Provides code
that is
> > > >
> >