search for: mlx5_vdpa

...), syndrome (0x5fa1c), err(-22) Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") Cc: Eli Cohen <elic at nvidia.com> Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> Reviewed-by: Eli Cohen <elic at nvidia.com> --- v3: move suspended to struct mlx5_vdpa_dev v2: removed the change for improving warning message --- drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/mlx5/core/mlx5_vdpa.h b/drivers/vdpa/mlx5/core/mlx5_vdpa.h index 058fbe2....

...gt; Fixes: cae15c2ed8e6 ("vdpa/mlx5: Implement susupend virtqueue callback") > Cc: Eli Cohen <elic at nvidia.com> > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Eli Cohen <elic at nvidia.com> > > --- > v3: move suspended to struct mlx5_vdpa_dev > v2: removed the change for improving warning message > --- > drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + > drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 +++++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/vdpa/mlx5/core/mlx5_vdpa.h b/drivers/vdpa/ml...

...are ordered like this for clarity. [0] https://lore.kernel.org/lkml/20230112142218.725622-1-eperezma at redhat.com/ Dragos Tatulea (1): vdpa/mlx5: Fix mr->initialized semantics Eugenio P?rez (1): vdpa/mlx5: Delete control vq iotlb in destroy_mr only when necessary drivers/vdpa/mlx5/core/mlx5_vdpa.h | 2 + drivers/vdpa/mlx5/core/mr.c | 97 +++++++++++++++++++++--------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +- 3 files changed, 74 insertions(+), 29 deletions(-) -- 2.41.0

...are ordered like this for clarity. [0] https://lore.kernel.org/lkml/20230112142218.725622-1-eperezma at redhat.com/ Dragos Tatulea (1): vdpa/mlx5: Fix mr->initialized semantics Eugenio P?rez (1): vdpa/mlx5: Delete control vq iotlb in destroy_mr only when necessary drivers/vdpa/mlx5/core/mlx5_vdpa.h | 2 + drivers/vdpa/mlx5/core/mr.c | 97 +++++++++++++++++++++--------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +- 3 files changed, 74 insertions(+), 29 deletions(-) -- 2.41.0

...("vdpa/mlx5: Implement susupend virtqueue callback") >> Cc: Eli Cohen <elic at nvidia.com> >> Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> >> Reviewed-by: Eli Cohen <elic at nvidia.com> >> >> --- >> v3: move suspended to struct mlx5_vdpa_dev >> v2: removed the change for improving warning message >> --- >> drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + >> drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 +++++- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/vdpa/mlx5/cor...

...ids.h> > #include <uapi/linux/vdpa.h> > +#include <uapi/linux/vhost_types.h> > #include <linux/virtio_config.h> > #include <linux/auxiliary_bus.h> > #include <linux/mlx5/cq.h> > @@ -2499,6 +2500,11 @@ static void unregister_link_notifier(struct mlx5_vdpa_net *ndev) > flush_workqueue(ndev->mvdev.wq); > } > > +static u64 mlx5_vdpa_get_backend_features(const struct vdpa_device *vdpa) > +{ > + return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK); > +} > + > static int mlx5_vdpa_set_driver_features(struct vdpa_devi...

...e <uapi/linux/vdpa.h> >> +#include <uapi/linux/vhost_types.h> >> #include <linux/virtio_config.h> >> #include <linux/auxiliary_bus.h> >> #include <linux/mlx5/cq.h> >> @@ -2499,6 +2500,11 @@ static void unregister_link_notifier(struct mlx5_vdpa_net *ndev) >> flush_workqueue(ndev->mvdev.wq); >> } >> >> +static u64 mlx5_vdpa_get_backend_features(const struct vdpa_device *vdpa) >> +{ >> + return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK); >> +} >> + >> static int mlx5_v...

Today, mlx5_vdpa gets started by preallocate 1:1 DMA mapping at device creation time, while this 1:1 mapping will be implicitly destroyed when the first .set_map call is invoked. Everytime when the .reset callback is invoked, any mapping left behind will be dropped then reset back to the initial 1:1 DMA mapping. I...

...y for the default 'vdpa dev add' behavior if dedicated >>>> device_features is not specified. Historically the default vdpa >>>> creation on mlx5 ever got changed from single queue to 8 queue pairs >>>> when VIRTIO_NET_F_MQ feature was first introduced to mlx5_vdpa, then >>>> the default switched back to 1 data queue pair again when max_vqp >> attribute was added to the vdpa tool. >>>> Essentially, every addition of new feature to mlx5_vdpa, e.g. >>>> CTRL_VQ, CTRL_VLAN, and et al, effectively changed the default &quo...

.../Kconfig b/drivers/vdpa/Kconfig > index 4271c408103e..57ff6a7f7401 100644 > --- a/drivers/vdpa/Kconfig > +++ b/drivers/vdpa/Kconfig > @@ -29,10 +29,9 @@ config IFCVF > To compile this driver as a module, choose M here: the module will > be called ifcvf. > > -config MLX5_VDPA > - bool "MLX5 VDPA support library for ConnectX devices" > +config MLX5_VDPA_CORE > + tristate "MLX5 VDPA support library for ConnectX devices" > depends on MLX5_CORE > - default n > help > Support library for Mellanox VDPA drivers. Provides code th...

...100644 > > > --- a/drivers/vdpa/Kconfig > > > +++ b/drivers/vdpa/Kconfig > > > @@ -29,10 +29,9 @@ config IFCVF > > > To compile this driver as a module, choose M here: the module will > > > be called ifcvf. > > > > > > -config MLX5_VDPA > > > - bool "MLX5 VDPA support library for ConnectX devices" > > > +config MLX5_VDPA_CORE > > > + tristate "MLX5 VDPA support library for ConnectX devices" > > > depends on MLX5_CORE > > > - default n > > > help > &gt...

...wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: >>>> --- linux-next-20200917.orig/drivers/vdpa/Kconfig >>>> +++ linux-next-20200917/drivers/vdpa/Kconfig >>>> @@ -31,7 +31,7 @@ config IFCVF >>>> >>>> config MLX5_VDPA >>>> bool "MLX5 VDPA support library for ConnectX devices" >>>> - depends on MLX5_CORE >>>> + depends on VHOST_IOTLB && MLX5_CORE >>>> default n >>> >>> While we are here, can anyone who apply this patch delete...

...wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: >>>> --- linux-next-20200917.orig/drivers/vdpa/Kconfig >>>> +++ linux-next-20200917/drivers/vdpa/Kconfig >>>> @@ -31,7 +31,7 @@ config IFCVF >>>> >>>> config MLX5_VDPA >>>> bool "MLX5 VDPA support library for ConnectX devices" >>>> - depends on MLX5_CORE >>>> + depends on VHOST_IOTLB && MLX5_CORE >>>> default n >>> >>> While we are here, can anyone who apply this patch delete...

...gt; > > +++ b/drivers/vdpa/Kconfig > > > > > @@ -29,10 +29,9 @@ config IFCVF > > > > > To compile this driver as a module, choose M here: the module will > > > > > be called ifcvf. > > > > > > > > > > -config MLX5_VDPA > > > > > - bool "MLX5 VDPA support library for ConnectX devices" > > > > > +config MLX5_VDPA_CORE > > > > > + tristate "MLX5 VDPA support library for ConnectX devices" > > > > > depends on MLX5_CORE > > > &g...

...-present page PGD 0 P4D 0 Oops: 0000 [#1] SMP CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 6.5.0-rc2_for_upstream_min_debug_2023_07_17_15_05 #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014 RIP: 0010:mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] RSP: 0018:ffff8881003bfdc0 EFLAGS: 00010286 RAX: ffff888103befba0 RBX: ffff888109d28008 RCX: 0000000000000017 RDX: 0000000000000001 RSI: 0000000000000212 RDI: ffff888109d28000 RBP: 0000000000000000 R08: 0000000d3a3a3882 R09: 0000000000000001 R10: 0000000000000000 R11: 0000000000000000 R12: ff...

...d-email-si-wei.liu at oracle.com/ --- Si-Wei Liu (4): vdpa: introduce .reset_map operation callback vdpa/mlx5: implement .reset_map driver op vhost-vdpa: should restore 1:1 dma mapping before detaching driver vhost-vdpa: introduce IOTLB_PERSIST backend feature bit drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + drivers/vdpa/mlx5/core/mr.c | 70 +++++++++++++++++++++++--------------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 18 +++++++--- drivers/vhost/vdpa.c | 32 ++++++++++++++++- include/linux/vdpa.h | 7 ++++ include/uapi/linux/vhost_types.h | 2 ++ 6 files...

...d-email-si-wei.liu at oracle.com/ --- Si-Wei Liu (4): vdpa: introduce .reset_map operation callback vdpa/mlx5: implement .reset_map driver op vhost-vdpa: should restore 1:1 dma mapping before detaching driver vhost-vdpa: introduce IOTLB_PERSIST backend feature bit drivers/vdpa/mlx5/core/mlx5_vdpa.h | 1 + drivers/vdpa/mlx5/core/mr.c | 70 +++++++++++++++++++++++--------------- drivers/vdpa/mlx5/net/mlx5_vnet.c | 18 +++++++--- drivers/vhost/vdpa.c | 32 ++++++++++++++++- include/linux/vdpa.h | 7 ++++ include/uapi/linux/vhost_types.h | 2 ++ 6 files...

...64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp at intel.com> All errors (new ones prefixed by >>): In file included from drivers/vdpa/mlx5/net/mlx5_vnet.c:12: >> drivers/vdpa/mlx5/net/mlx5_vnet.h:13:10: fatal error: 'mlx5_vdpa.h' file not found #include "mlx5_vdpa.h" ^~~~~~~~~~~~~ 1 error generated. vim +13 drivers/vdpa/mlx5/net/mlx5_vnet.h 6 7 #include <linux/vdpa.h> 8 #include <linux/virtio_net.h> 9 #include <linux/vringh.h> 10 #include <li...

...wording in the subject of patch v2 -> v3: - fix incorrect reference of local variable in future patch - prohibit per-device bitmask macro from exposure in uapi header - add fixes tag v1 -> v2: - include specific attribute info to error message - move conditional feature presence in mlx5_vdpa config space to a separate patch - remove redundant check --- Si-Wei Liu (6): vdpa: fix improper error message when adding vdpa dev vdpa: conditionally read STATUS in config space vdpa: validate provisioned device features against specified attribute vdpa: validate device feature pro...

...> > > > > @@ -29,10 +29,9 @@ config IFCVF > > > > > > > To compile this driver as a module, choose M here: the module will > > > > > > > be called ifcvf. > > > > > > > > > > > > > > -config MLX5_VDPA > > > > > > > - bool "MLX5 VDPA support library for ConnectX devices" > > > > > > > +config MLX5_VDPA_CORE > > > > > > > + tristate "MLX5 VDPA support library for ConnectX devices" > > > > > > >...