Linux Virtualization - Mar 2020 - [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON_COMPACTION

> Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino at
arm.com>:
> 
> ?out_del_vqs label is currently used only when BALLOON_COMPACTION
> configuration option is enabled. Having it disabled triggers the
> following warning at compile time:
> 
> drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?:
> drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs?
> defined but not used [-Wunused-label]
>  963 | out_del_vqs:
>      | ^~~~~~~~~~~
> 
> Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> issue.
> 
> Cc: "Michael S. Tsirkin" <mst at redhat.com>
> Cc: Jason Wang <jasowang at redhat.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino at arm.com>
I think this is now the third patch on the list that tries to fix this warning.

Michael, can we finally queue one of these (or is there one in -next already -
did not check)?

Thanks

On Sun, Mar 08, 2020 at 08:38:19PM +0100, David Hildenbrand
wrote:
> 
> 
> > Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino
at arm.com>:
> > 
> > ?out_del_vqs label is currently used only when BALLOON_COMPACTION
> > configuration option is enabled. Having it disabled triggers the
> > following warning at compile time:
> > 
> > drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?:
> > drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs?
> > defined but not used [-Wunused-label]
> >  963 | out_del_vqs:
> >      | ^~~~~~~~~~~
> > 
> > Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> > issue.
> > 
> > Cc: "Michael S. Tsirkin" <mst at redhat.com>
> > Cc: Jason Wang <jasowang at redhat.com>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino at arm.com>
> 
> I think this is now the third patch on the list that tries to fix this
warning.
> 
> Michael, can we finally queue one of these (or is there one in -next
already - did not check)?
> 
> Thanks
It's queued in my tree (and will be in next eventually), I just didn't
send it to Linus yet.
Sorry about the delay.

-- 
MST