search for: balloon_compaction

This patch is a revert of 'commit bb01b64cfab7 ("mm/balloon_compaction.c: enqueue zero page to balloon device")' Ballooned pages will be marked as MADV_DONTNEED by the hypervisor and shouldn't be given to the host ksmd to scan. Therefore, it is not necessary to zero ballooned pages, which is very time consuming when the page amount is large. The ongoing...

This patch is a revert of 'commit bb01b64cfab7 ("mm/balloon_compaction.c: enqueue zero page to balloon device")' Ballooned pages will be marked as MADV_DONTNEED by the hypervisor and shouldn't be given to the host ksmd to scan. Therefore, it is not necessary to zero ballooned pages, which is very time consuming when the page amount is large. The ongoing...

Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be> --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index ba739b76e6c52e55..17ac81d8d26bcb50 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -60,7 +60,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); /* * ba...

Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be> --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index ba739b76e6c52e55..17ac81d8d26bcb50 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -60,7 +60,7 @@ EXPORT_SYMBOL_GPL(balloon_page_enqueue); /* * ba...

...d-by: Souptick Joarder <jrdr.linux at gmail.com> > > Fix it up accordingly: > decriptors -> descriptors > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas at ideasonboard.com> > Reviewed-by: David Hildenbrand <david at redhat.com> > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 26de020aae7b..907fefde2572 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(ballo...

...om> > Cc: linux-mm at kvack.org > Cc: virtualization at lists.linux-foundation.org > Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> > Signed-off-by: Nadav Amit <namit at vmware.com> Looks good overall. Two minor comments below. > --- > include/linux/balloon_compaction.h | 4 + > mm/balloon_compaction.c | 144 +++++++++++++++++++++-------- > 2 files changed, 110 insertions(+), 38 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index f111c780ef1d..430b6047cef7 100644 > --- a/in...

...-[ end trace 43cf28060d708d5f ]--- > Kernel panic - not syncing: Fatal exception > Dumping ftrace buffer: > (ftrace buffer empty) > Kernel Offset: disabled > > Cc: <stable at vger.kernel.org> > Signed-off-by: Minchan Kim <minchan at kernel.org> > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index d3116be5a00f..300117f1a08f 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -61,6 +61,7 @@ struct page *balloon_p...

...-[ end trace 43cf28060d708d5f ]--- > Kernel panic - not syncing: Fatal exception > Dumping ftrace buffer: > (ftrace buffer empty) > Kernel Offset: disabled > > Cc: <stable at vger.kernel.org> > Signed-off-by: Minchan Kim <minchan at kernel.org> > --- > mm/balloon_compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index d3116be5a00f..300117f1a08f 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -61,6 +61,7 @@ struct page *balloon_p...

...Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: linux-mm at kvack.org Cc: virtualization at lists.linux-foundation.org Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> Signed-off-by: Nadav Amit <namit at vmware.com> --- include/linux/balloon_compaction.h | 4 + mm/balloon_compaction.c | 144 +++++++++++++++++++++-------- 2 files changed, 110 insertions(+), 38 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index f111c780ef1d..430b6047cef7 100644 --- a/include/linux/balloon_compaction...

...<jasowang at redhat.com> Cc: linux-mm at kvack.org Cc: virtualization at lists.linux-foundation.org Acked-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> Signed-off-by: Nadav Amit <namit at vmware.com> --- include/linux/balloon_compaction.h | 4 + mm/balloon_compaction.c | 144 +++++++++++++++++++++-------- 2 files changed, 110 insertions(+), 38 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index f111c780ef1d..430b6047cef7 100644 --- a/include/linux/balloon_compaction...

...m> > Cc: Jason Wang <jasowang at redhat.com> > Cc: linux-mm at kvack.org > Cc: virtualization at lists.linux-foundation.org > Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> > Signed-off-by: Nadav Amit <namit at vmware.com> > --- > include/linux/balloon_compaction.h | 4 + > mm/balloon_compaction.c | 139 +++++++++++++++++++++-------- > 2 files changed, 105 insertions(+), 38 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index 53051f3d8f25..2c5a8e09e413 100644 > --- a/in...

...d pages, which is very time consuming when the page amount is large. The ongoing fast balloon tests show that the time to balloon 7G pages is increased from ~491ms to 2.8 seconds with __GFP_ZERO added. So, this patch removes the flag. Signed-off-by: Wei Wang <wei.w.wang at intel.com> --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 9075aa5..b06d9fe 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -24,7 +24,7 @@ struct page *balloon_page_enqueue(struct balloon_dev_info *b_dev_info)...

...d pages, which is very time consuming when the page amount is large. The ongoing fast balloon tests show that the time to balloon 7G pages is increased from ~491ms to 2.8 seconds with __GFP_ZERO added. So, this patch removes the flag. Signed-off-by: Wei Wang <wei.w.wang at intel.com> --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 9075aa5..b06d9fe 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -24,7 +24,7 @@ struct page *balloon_page_enqueue(struct balloon_dev_info *b_dev_info)...

...m> > Cc: Jason Wang <jasowang at redhat.com> > Cc: linux-mm at kvack.org > Cc: virtualization at lists.linux-foundation.org > Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> > Signed-off-by: Nadav Amit <namit at vmware.com> > --- > include/linux/balloon_compaction.h | 4 + > mm/balloon_compaction.c | 145 +++++++++++++++++++++-------- > 2 files changed, 111 insertions(+), 38 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index f111c780ef1d..1da79edadb69 100644 > --- a/in...

...A.ne.jp> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Cc: Michal Hocko <mhocko at suse.com> Cc: Wei Wang <wei.w.wang at intel.com> Reviewed-by: Wei Wang <wei.w.wang at intel.com> --- drivers/virtio/virtio_balloon.c | 23 ++++++++++++++++++----- include/linux/balloon_compaction.h | 34 +++++++++++++++++++++++++++++++++- mm/balloon_compaction.c | 28 +++++++++++++++++++++------- 3 files changed, 72 insertions(+), 13 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f0b3a0b..45fe6a8 100644 --- a/drivers/virtio/virt...

Changes to mm/balloon_compaction.c can easily break virtio, and virtio is the only user of that interface. Add a line to MAINTAINERS so whoever changes that file remembers to copy us. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAI...

Changes to mm/balloon_compaction.c can easily break virtio, and virtio is the only user of that interface. Add a line to MAINTAINERS so whoever changes that file remembers to copy us. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAI...

...gt; > >> Cc: linux-mm at kvack.org > >> Cc: virtualization at lists.linux-foundation.org > >> Reviewed-by: Xavier Deguillard <xdeguillard at vmware.com> > >> Signed-off-by: Nadav Amit <namit at vmware.com> > >> --- > >> include/linux/balloon_compaction.h | 4 + > >> mm/balloon_compaction.c | 145 +++++++++++++++++++++-------- > >> 2 files changed, 111 insertions(+), 38 deletions(-) > >> > >> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > >> index f111...

...: Wei Wang <wei.w.wang at intel.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes since v2: drop an unused declaration, reported by Tetsuo Hocko Changes from v1: fix a build warning drivers/virtio/virtio_balloon.c | 24 +++++++++++++++++++----- include/linux/balloon_compaction.h | 35 ++++++++++++++++++++++++++++++++++- mm/balloon_compaction.c | 28 +++++++++++++++++++++------- 3 files changed, 74 insertions(+), 13 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f0b3a0b..7960746 100644 --- a/drivers/virtio/vir...

...: Wei Wang <wei.w.wang at intel.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes since v2: drop an unused declaration, reported by Tetsuo Hocko Changes from v1: fix a build warning drivers/virtio/virtio_balloon.c | 24 +++++++++++++++++++----- include/linux/balloon_compaction.h | 35 ++++++++++++++++++++++++++++++++++- mm/balloon_compaction.c | 28 +++++++++++++++++++++------- 3 files changed, 74 insertions(+), 13 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f0b3a0b..7960746 100644 --- a/drivers/virtio/vir...