search for: virtballoon_probe

...n.c:963:1: warning: unused label 'out_del_vqs' [-Wunused-label] out_del_vqs: ^~~~~~~~~~~~ 1 warning generated. Move the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") Link: https://github.com/ClangBuiltLinux/linux/issues/886 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_ba...

...n.c:963:1: warning: unused label 'out_del_vqs' [-Wunused-label] out_del_vqs: ^~~~~~~~~~~~ 1 warning generated. Move the label within the preprocessor block since it is only used when CONFIG_BALLOON_COMPACTION is set. Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") Link: https://github.com/ClangBuiltLinux/linux/issues/886 Signed-off-by: Nathan Chancellor <natechancellor at gmail.com> --- drivers/virtio/virtio_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_ba...

>> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) >> VIRTIO_BALLOON_CMD_ID_STOP); >> spin_lock_init(&vb->free_page_list_lock); >> INIT_LIST_HEAD(&vb->free_page_list); >> + /* >> + * We're allowed to reuse any free pages, even if they are >> + * st...

>> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) >> VIRTIO_BALLOON_CMD_ID_STOP); >> spin_lock_init(&vb->free_page_list_lock); >> INIT_LIST_HEAD(&vb->free_page_list); >> + /* >> + * We're allowed to reuse any free pages, even if they are >> + * st...

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David Hildenbrand <david at...

From: Borislav Petkov <bp at suse.de> Fix drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] 963 | out_del_vqs: | ^~ The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: David Hildenbrand <david at...

...on.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index abef2306c899..7e5d84caeb94 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -901,8 +901,7 @@ static int virtballoon_probe(struct virtio_device *vdev) vb->vb_dev_info.inode = alloc_anon_inode(balloon_mnt->mnt_sb); if (IS_ERR(vb->vb_dev_info.inode)) { err = PTR_ERR(vb->vb_dev_info.inode); - kern_unmount(balloon_mnt); - goto out_del_vqs; + goto out_kern_unmount; } vb->vb_dev_info.inode->i_...

> Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor at gmail.com>: > > ?Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label > 'out_del_vqs' [-Wunused-label] > out_del_vqs: > ^~~~~~~~~~~~ > 1 warning generated. > Thanks, there is already ? [PATCH] virtio_balloon: Fix

On Sun, Feb 16, 2020 at 08:36:45AM +0100, David Hildenbrand wrote: > > > > Am 16.02.2020 um 01:41 schrieb Nathan Chancellor <natechancellor at gmail.com>: > > > > ?Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label > > 'out_del_vqs' [-Wunused-label] > >

0day reports: drivers//virtio/virtio_balloon.c: In function 'virtballoon_probe': drivers//virtio/virtio_balloon.c:960:1: error: label 'out_del_vqs' defined but not used [-Werror=unused-label] This is seen with CONFIG_BALLOON_COMPACTION=n. Reported-by: kbuild test robot <lkp at intel.com> Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on error...

On Tue, Mar 10, 2020 at 12:12:50PM +0100, David Hildenbrand wrote: > >> static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) > >> @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) > >> VIRTIO_BALLOON_CMD_ID_STOP); > >> spin_lock_init(&vb->free_page_list_lock); > >> INIT_LIST_HEAD(&vb->free_page_list); > >> + /* > >> + * We're allowed to reuse any free pages, even if t...

...oom_nb); + unsigned long *freed = parm; + + *freed += leak_balloon(vb, VIRTIO_BALLOON_OOM_NR_PAGES) / + VIRTIO_BALLOON_PAGES_PER_PAGE; + update_balloon_size(vb); + + return NOTIFY_OK; } static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) VIRTIO_BALLOON_CMD_ID_STOP); spin_lock_init(&vb->free_page_list_lock); INIT_LIST_HEAD(&vb->free_page_list); + /* + * We're allowed to reuse any free pages, even if they are + * still to be processed by the host. + */ + err = virti...

...oom_nb); + unsigned long *freed = parm; + + *freed += leak_balloon(vb, VIRTIO_BALLOON_OOM_NR_PAGES) / + VIRTIO_BALLOON_PAGES_PER_PAGE; + update_balloon_size(vb); + + return NOTIFY_OK; } static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) @@ -971,7 +950,22 @@ static int virtballoon_probe(struct virtio_device *vdev) VIRTIO_BALLOON_CMD_ID_STOP); spin_lock_init(&vb->free_page_list_lock); INIT_LIST_HEAD(&vb->free_page_list); + /* + * We're allowed to reuse any free pages, even if they are + * still to be processed by the host. + */ + err = virti...

...s go through your tree? Patch #1 contains a proper description. v3 -> v4: - Add Ack from David Rientjes - Minor tweaks to test details in the patch description v2 -> v3: - Use vb->vdev instead of vdev in all feature checks. We'll clean the other ones up later. - Add one empty line virtballoon_probe() to make it look consistent. - Drop one unrelated added line in virtballoon_remove() v1 -> v2: - Rebase on top of linux-next (free page reporting) - Clarified some parts in the patch description and added testing instructions/results - Added Fixes: and Tested-by: David Hildenbrand (1): vi...

On Mon, Feb 10, 2020 at 10:33:28AM +0100, Borislav Petkov wrote: > From: Borislav Petkov <bp at suse.de> > > Fix > > drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?: > drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label] > 963 | out_del_vqs: > | ^~ > > The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too. > > Signed-off-by: Borislav Petkov <bp at suse.de>...

...m> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 5a6ad6d..6a356e3 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -508,6 +508,8 @@ static int virtballoon_probe(struct virtio_device *vdev) if (err < 0) goto out_oom_notify; + virtio_device_ready(vdev); + vb->thread = kthread_run(balloon, vb, "vballoon"); if (IS_ERR(vb->thread)) { err = PTR_ERR(vb->thread); -- MST

...m> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 5a6ad6d..6a356e3 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -508,6 +508,8 @@ static int virtballoon_probe(struct virtio_device *vdev) if (err < 0) goto out_oom_notify; + virtio_device_ready(vdev); + vb->thread = kthread_run(balloon, vb, "vballoon"); if (IS_ERR(vb->thread)) { err = PTR_ERR(vb->thread); -- MST

This series is split from the "Virtio-balloon: support free page reporting" series to make some improvements. v1->v2 ChangeLog: - register the shrinker when VIRTIO_BALLOON_F_DEFLATE_ON_OOM is negotiated. Wei Wang (2): virtio-balloon: remove BUG() in init_vqs virtio_balloon: replace oom notifier with shrinker drivers/virtio/virtio_balloon.c | 125

This series is split from the "Virtio-balloon: support free page reporting" series to make some improvements. v1->v2 ChangeLog: - register the shrinker when VIRTIO_BALLOON_F_DEFLATE_ON_OOM is negotiated. Wei Wang (2): virtio-balloon: remove BUG() in init_vqs virtio_balloon: replace oom notifier with shrinker drivers/virtio/virtio_balloon.c | 125

...wq, to_delayed_work(work), + delay); } static int init_vqs(struct virtio_balloon *vb) @@ -521,6 +537,10 @@ static struct dentry *balloon_mount(struct file_system_type *fs_type, #endif /* CONFIG_BALLOON_COMPACTION */ +static void timer_expired(unsigned long unused) +{ +} + static int virtballoon_probe(struct virtio_device *vdev) { struct virtio_balloon *vb; @@ -539,7 +559,8 @@ static int virtballoon_probe(struct virtio_device *vdev) } INIT_WORK(&vb->update_balloon_stats_work, update_balloon_stats_func); - INIT_WORK(&vb->update_balloon_size_work, update_balloon_size_func);...