On Fri, Sep 22, 2023 at 06:33:06AM +0100, Bhasker C V wrote:> I finally fixed it. > The issue seems to be with the tpm-tis/cpu backend (wonder why it shows up > with a different error) > For the sake of community, I am attaching the new xml file so that you can > do forensics on what changed > (I prettymuch did a virt-install --import --print-xml to redo the config > keeping everything intact)Glad to hear you managed to make it work!> I found another issue > If I switch the suspend-to-disk enabled="yes" > I strangely get an error > error: operation failed: Unable to find any firmware to satisfy 'efi'I can explain that one. suspend-to-disk.enabled=yes requires a firmware image that advertises the acpi-s4 feature, and you probably don't have one on your system. For example, on my Fedora 38 machine: $ grep acpi-s4 /usr/share/qemu/firmware/*.json $ Yeah, the error message is not very helpful. Unfortunately, due to the way firmware autoselection works, emitting a better one would be pretty much impossible :( -- Andrea Bolognani / Red Hat / Virtualization
On 9/22/23 10:34, Andrea Bolognani wrote:> On Fri, Sep 22, 2023 at 06:33:06AM +0100, Bhasker C V wrote: >> I finally fixed it. >> The issue seems to be with the tpm-tis/cpu backend (wonder why it shows up >> with a different error) >> For the sake of community, I am attaching the new xml file so that you can >> do forensics on what changed >> (I prettymuch did a virt-install --import --print-xml to redo the config >> keeping everything intact) > > Glad to hear you managed to make it work! > >> I found another issue >> If I switch the suspend-to-disk enabled="yes" >> I strangely get an error >> error: operation failed: Unable to find any firmware to satisfy 'efi' > > I can explain that one. > > suspend-to-disk.enabled=yes requires a firmware image that advertises > the acpi-s4 feature, and you probably don't have one on your system. > > For example, on my Fedora 38 machine: > > $ grep acpi-s4 /usr/share/qemu/firmware/*.json > $ > > Yeah, the error message is not very helpful. Unfortunately, due to > the way firmware autoselection works, emitting a better one would be > pretty much impossible :( >You can enable debug logs and then observe why each one FW was rejected (see those VIR_DEBUG() printings in qemuFirmwareMatchDomain() [1]). 1: https://gitlab.com/libvirt/libvirt/-/blob/master/src/qemu/qemu_firmware.c?ref_type=heads#L1174 Michal
On 22 Sep 2023 01:34 -0700, from abologna at redhat.com (Andrea Bolognani):>> If I switch the suspend-to-disk enabled="yes" >> I strangely get an error >> error: operation failed: Unable to find any firmware to satisfy 'efi' > > I can explain that one. > > suspend-to-disk.enabled=yes requires a firmware image that advertises > the acpi-s4 feature, and you probably don't have one on your system. > > For example, on my Fedora 38 machine: > > $ grep acpi-s4 /usr/share/qemu/firmware/*.json > $ > > Yeah, the error message is not very helpful. Unfortunately, due to > the way firmware autoselection works, emitting a better one would be > pretty much impossible :(Might a simple fix to make the error message at least slightly more helpful be to change it to something like: "Unable to find any firmware to satisfy '<whatever>' with specified settings" That would make it clearer that it isn't _necessarily_ the "efi" part (or whatever it happens to be in the specific case) which is the actual, _specific_ problem. -- Michael Kj?rling ??https://michael.kjorling.se ?Remember when, on the Internet, nobody cared that you were a dog??