Cool. I'll try it out On Thu, Apr 16, 2020 at 8:38 AM Michal Privoznik <mprivozn@redhat.com> wrote:> > On 4/14/20 6:49 PM, Todd Lewis wrote: > > I was looking for a virDomainSnapshotCurrent > > I wish I had time to learn to properly Code in C, haven't touch it > > since that late 90's > > I'm only only coding in php out of necessity. > > > I've just pushed the implementation upstream: > > https://gitlab.com/libvirt/libvirt-php/-/commit/19be5d2b5b2d3b82d719fe310ad519cb3b5d7ebf > > Michal >-- Todd Lewis Grizzly Star (469) 363-2907 Cell www.grizzlystar.com
Works perfectly thank you.
I did get an issue when trying to compile an rpm
The autobuild did run into an error when trying to create the rpm.
Not a big deal. I can make my own spec file.
EXTRA_RELEASE=""
if [ -x /usr/bin/rpmbuild ]
then
rpmbuild --nodeps \
--define "extra_release $EXTRA_RELEASE" \
--define "_sourcedir `pwd`" \
-ba --clean libvirt-php.spec
fi
pwd
error: Macro %extra_release has empty body
error: Macro %extra_release has empty body
error: Macro %extra_release has empty body
On Thu, Apr 16, 2020 at 11:50 AM Todd Lewis <todd@grizzlystar.com>
wrote:>
> Cool. I'll try it out
>
> On Thu, Apr 16, 2020 at 8:38 AM Michal Privoznik
<mprivozn@redhat.com> wrote:
> >
> > On 4/14/20 6:49 PM, Todd Lewis wrote:
> > > I was looking for a virDomainSnapshotCurrent
> > > I wish I had time to learn to properly Code in C, haven't
touch it
> > > since that late 90's
> > > I'm only only coding in php out of necessity.
> >
> >
> > I've just pushed the implementation upstream:
> >
> >
https://gitlab.com/libvirt/libvirt-php/-/commit/19be5d2b5b2d3b82d719fe310ad519cb3b5d7ebf
> >
> > Michal
> >
>
>
> --
> Todd Lewis
> Grizzly Star
> (469) 363-2907 Cell
> www.grizzlystar.com
--
Todd Lewis
Grizzly Star
(469) 363-2907 Cell
www.grizzlystar.com
On 4/21/20 1:36 AM, Todd Lewis wrote:> Works perfectly thank you. > I did get an issue when trying to compile an rpm > > The autobuild did run into an error when trying to create the rpm. > Not a big deal. I can make my own spec file. > > EXTRA_RELEASE=""1: ^^^> if [ -x /usr/bin/rpmbuild ] > then > rpmbuild --nodeps \ > --define "extra_release $EXTRA_RELEASE" \ > --define "_sourcedir `pwd`" \ > -ba --clean libvirt-php.spec > fi > pwd > error: Macro %extra_release has empty body > error: Macro %extra_release has empty body > error: Macro %extra_release has empty bodyD'oh. The line [1] shouldn't be there. But actually, whole autobuild script is a bit misleading. The way I build RPMs is autogen.sh + make rpm. Would you mind if I remove the autobuild script? Michal