Libguestfs - Nov 2019 - Re: [PATCH] tests: rhv-upload: Require nbdkit python plugin

With recent nbdkit the skip test fails the rhv-upload test skip:

    $ nbdkit python3 --version
    nbdkit: error: cannot open plugin 'python3':
    /usr/local/lib/nbdkit/plugins/nbdkit-python3-plugin.so: cannot open
    shared object file: No such file or directory

It seems that the python plugin is always installed as
nbdkit-python-plugin.so, so the correct test now is:

    nbdkit python --version

This may not work with older version of nbdkit, but I'm not sure this is
relevant now.
---
 tests/test-v2v-o-rhv-upload.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/test-v2v-o-rhv-upload.sh b/tests/test-v2v-o-rhv-upload.sh
index a2f5b0d5..fe0a4d94 100755
--- a/tests/test-v2v-o-rhv-upload.sh
+++ b/tests/test-v2v-o-rhv-upload.sh
@@ -29,7 +29,7 @@ $TEST_FUNCTIONS
 skip_if_skipped
 skip_if_backend uml
 skip_unless python3 --version
-skip_unless nbdkit python3 --version
+skip_unless nbdkit python --version
 skip_unless_phony_guest windows.img
 
 libvirt_uri="test://$abs_top_builddir/test-data/phony-guests/guests.xml"
-- 
2.21.0

This will break for people using
./configure --with-virt-v2v-nbdkit-python-plugin=...

We could probably drop that option, but that complicated RHEL.
Otherwise the rather more complicated patch attached is needed.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

On Friday, 29 November 2019 09:02:50 CET Richard W.M. Jones
wrote:
> Otherwise the rather more complicated patch attached is needed.
This looks like what we did in libguestfs for a couple of tests, so
IMHO it is OK.

Another possible approach is to output VIRT_V2V_NBDKIT_PYTHON_PLUGIN
(and any other variable needed in shell scripts used only at
build/test time) to a new config.sh file, and source that as part of
the TEST_FUNCTIONS stuff.

-- 
Pino Toscano