Libguestfs - Jun 2016 - Re: [PATCH] p2v: kiwi: make sure launch-virt-p2v is executable

virt-p2v-make-kiwi now forces the launch-virt-p2v mode to 0755 to
ensure the executable bit it set for user.
---
 p2v/virt-p2v-make-kiwi.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/p2v/virt-p2v-make-kiwi.in b/p2v/virt-p2v-make-kiwi.in
index e493bd4..3506e9b 100644
--- a/p2v/virt-p2v-make-kiwi.in
+++ b/p2v/virt-p2v-make-kiwi.in
@@ -190,6 +190,7 @@ cp $datadir/issue $output/root/etc/issue
 
 mkdir -p $output/root/usr/bin
 cp $datadir/launch-virt-p2v $output/root/usr/bin
+chmod 0755 $output/root/usr/bin/launch-virt-p2v
 
 mkdir -p $output/root/$libexecdir
 cp $host_libexecdir/virt-p2v $output/root/$libexecdir
-- 
2.6.6

On Thu, Jun 23, 2016 at 10:18:02AM +0200, Cédric Bosdonnat
wrote:
> virt-p2v-make-kiwi now forces the launch-virt-p2v mode to 0755 to
> ensure the executable bit it set for user.
> ---
>  p2v/virt-p2v-make-kiwi.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/p2v/virt-p2v-make-kiwi.in b/p2v/virt-p2v-make-kiwi.in
> index e493bd4..3506e9b 100644
> --- a/p2v/virt-p2v-make-kiwi.in
> +++ b/p2v/virt-p2v-make-kiwi.in
> @@ -190,6 +190,7 @@ cp $datadir/issue $output/root/etc/issue
>  
>  mkdir -p $output/root/usr/bin
>  cp $datadir/launch-virt-p2v $output/root/usr/bin
> +chmod 0755 $output/root/usr/bin/launch-virt-p2v
>  
>  mkdir -p $output/root/$libexecdir
>  cp $host_libexecdir/virt-p2v $output/root/$libexecdir
It should already have mode 0555 (see p2v/Makefile.am).

Unless it specifically requires 0755 (instead of 0555) for some
reason, I don't see why this patch is necessary.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Thu, 2016-06-23 at 09:51 +0100, Richard W.M. Jones
wrote:
> On Thu, Jun 23, 2016 at 10:18:02AM +0200, Cédric Bosdonnat wrote:
> > virt-p2v-make-kiwi now forces the launch-virt-p2v mode to 0755 to
> > ensure the executable bit it set for user.
> > ---
> >  p2v/virt-p2v-make-kiwi.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/p2v/virt-p2v-make-kiwi.in b/p2v/virt-p2v-make-kiwi.in
> > index e493bd4..3506e9b 100644
> > --- a/p2v/virt-p2v-make-kiwi.in
> > +++ b/p2v/virt-p2v-make-kiwi.in
> > @@ -190,6 +190,7 @@ cp $datadir/issue $output/root/etc/issue
> >  
> >  mkdir -p $output/root/usr/bin
> >  cp $datadir/launch-virt-p2v $output/root/usr/bin
> > +chmod 0755 $output/root/usr/bin/launch-virt-p2v
> >  
> >  mkdir -p $output/root/$libexecdir
> >  cp $host_libexecdir/virt-p2v $output/root/$libexecdir
> 
> It should already have mode 0555 (see p2v/Makefile.am).
> 
> Unless it specifically requires 0755 (instead of 0555) for some
> reason, I don't see why this patch is necessary.
Hum... you're right. That is surely a trick of my spec file.

--
Cedric