Libguestfs - Mar 2016 - Re: [PATCH supermin 5/5] init: Drop SCSI modules.

On 03/17/2016 12:07, Richard W.M. Jones wrote:
> Also drop the sr_mod module used by the deprecated guestfs_add_cdrom
> interface.
> ---
>  src/ext2_initrd.ml | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml
> index 730f806..5e841ea 100644
> --- a/src/ext2_initrd.ml
> +++ b/src/ext2_initrd.ml
> @@ -40,12 +40,7 @@ let kmods = [
> -  "sd_mod.ko*";
sd_mod.ko is required on Debian jessie (with kernel from backports
4.3.0-0.bpo.1-amd64), otherwise it won't find /sys/block/sdb/dev.

Best regards,
-- 
Edwin Török | Co-founder and Lead Developer

Skylable open-source object storage: reliable, fast, secure
http://www.skylable.com

On Sun, Mar 20, 2016 at 01:30:17PM +0200, Török Edwin
wrote:
> On 03/17/2016 12:07, Richard W.M. Jones wrote:
> > Also drop the sr_mod module used by the deprecated guestfs_add_cdrom
> > interface.
> > ---
> >  src/ext2_initrd.ml | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml
> > index 730f806..5e841ea 100644
> > --- a/src/ext2_initrd.ml
> > +++ b/src/ext2_initrd.ml
> > @@ -40,12 +40,7 @@ let kmods = [
> > -  "sd_mod.ko*";
>
> sd_mod.ko is required on Debian jessie (with kernel from backports
> 4.3.0-0.bpo.1-amd64), otherwise it won't find /sys/block/sdb/dev.
Agreed.  On Fedora it's compiled in, and also I notice that the
virtio-scsi module doesn't require it so it won't be pulled in by
module dependencies.

scsi_mod.ko seems like it might be in a similar situation?

I'll partially revert this patch, just sd_mod.ko for now.

BTW please see also my series on analyzing the launch process.  You
might find it interesting.  I'll post an updated patch series in a
moment.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

On 03/20/2016 14:20, Richard W.M. Jones wrote:
> On Sun, Mar 20, 2016 at 01:30:17PM +0200, Török Edwin wrote:
>> On 03/17/2016 12:07, Richard W.M. Jones wrote:
>>> Also drop the sr_mod module used by the deprecated
guestfs_add_cdrom
>>> interface.
>>> ---
>>>  src/ext2_initrd.ml | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>> diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml
>>> index 730f806..5e841ea 100644
>>> --- a/src/ext2_initrd.ml
>>> +++ b/src/ext2_initrd.ml
>>> @@ -40,12 +40,7 @@ let kmods = [
>>> -  "sd_mod.ko*";
>>
>> sd_mod.ko is required on Debian jessie (with kernel from backports
>> 4.3.0-0.bpo.1-amd64), otherwise it won't find /sys/block/sdb/dev.
> 
> Agreed.  On Fedora it's compiled in, and also I notice that the
> virtio-scsi module doesn't require it so it won't be pulled in by
> module dependencies.
> 
> scsi_mod.ko seems like it might be in a similar situation?
scsi_mod gets pulled in by sd_mod so depending just on sd_mod seems to be
enough:
kernel/drivers/scsi/sd_mod.ko: kernel/drivers/scsi/scsi_mod.ko
> 
> I'll partially revert this patch, just sd_mod.ko for now.
supermin HEAD works on Debian again now, thanks!

FWIW this is the full list of what gets loaded on Debian:

guestfish -a /dev/null run -v 2>&1|grep insmod
supermin: internal insmod crc32-pclmul.ko
supermin: internal insmod crc32c-intel.ko
supermin: internal insmod crct10dif-pclmul.ko
supermin: internal insmod crc32.ko
supermin: internal insmod crc32c_generic.ko
supermin: internal insmod scsi_mod.ko
supermin: internal insmod libata.ko
supermin: internal insmod ata_piix.ko
supermin: internal insmod virtio.ko
supermin: internal insmod virtio_ring.ko
supermin: internal insmod virtio_blk.ko
supermin: internal insmod rng-core.ko
supermin: internal insmod virtio-rng.ko
supermin: internal insmod virtio_console.ko
supermin: internal insmod virtio_net.ko
supermin: internal insmod sd_mod.ko
supermin: internal insmod virtio_scsi.ko
supermin: internal insmod virtio_balloon.ko
supermin: internal insmod virtio_input.ko
supermin: internal insmod virtio_pci.ko
supermin: internal insmod jbd2.ko
supermin: internal insmod mbcache.ko
supermin: internal insmod crc16.ko
supermin: internal insmod ext4.ko
supermin: internal insmod crc-ccitt.ko
supermin: internal insmod crc-itu-t.ko
supermin: internal insmod crc7.ko
supermin: internal insmod libcrc32c.ko

> 
> BTW please see also my series on analyzing the launch process.  You
> might find it interesting.
I do, was trying to see if I can get QBoot working to compare but no luck.

>  I'll post an updated patch series in a
> moment.
Thanks, will followup there.


Best regards,
-- 
Edwin Török | Co-founder and Lead Developer

Skylable open-source object storage: reliable, fast, secure
http://www.skylable.com