search for: guestfs_add_cdrom

On 03/17/2016 12:07, Richard W.M. Jones wrote: > Also drop the sr_mod module used by the deprecated guestfs_add_cdrom > interface. > --- > src/ext2_initrd.ml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml > index 730f806..5e841ea 100644 > --- a/src/ext2_initrd.ml > +++ b/src/ext2_initrd.ml > @@ -40,12 +40,7 @@ let kmods = [ >...

Various patches to make supermin quieter. By outputting fewer messages on the fast path, we use the slow emulated UART less, and this improves boot times. Also remove some kernel modules that we cannot or should not be using, which also improves boot times. Rich.

Also drop the sr_mod module used by the deprecated guestfs_add_cdrom interface. --- src/ext2_initrd.ml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml index 730f806..5e841ea 100644 --- a/src/ext2_initrd.ml +++ b/src/ext2_initrd.ml @@ -40,12 +40,7 @@ let kmods = [ "virtio*.ko*"; "libata*.ko*";...

On Sun, Mar 20, 2016 at 01:30:17PM +0200, Török Edwin wrote: > On 03/17/2016 12:07, Richard W.M. Jones wrote: > > Also drop the sr_mod module used by the deprecated guestfs_add_cdrom > > interface. > > --- > > src/ext2_initrd.ml | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/src/ext2_initrd.ml b/src/ext2_initrd.ml > > index 730f806..5e841ea 100644 > > --- a/src/ext2_initrd.ml > > +++ b/src/ext2_initrd.m...

...you'll probably need to add this: if [ ! -s ../guests/fedora.img -o ! -s ../guests/debian.img ]; then echo "$0: test skipped because there is no fedora.img or debian.img" exit 77 fi --- Also, should we update the documentation? http://libguestfs.org/guestfs.3.html#guestfs_add_cdrom Maybe or maybe not worth it. --- Patch looks good apart from these three small issues. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

The current add_cdrom way basically appends a new raw "-cdrom /path" parameter to the qemu invocation (even when using libvirt as backend), hence such images are seen as "CD-ROM drives" inside the appliance. However, there is no need for such particular behaviour, as they need to be handled as normal (read-only) drives. Adding CD-ROM disk images as drives also changes the

...become just: > > int > guestfs__add_cdrom (guestfs_h *g, const char *filename) > { > return guestfs__add_drive_ro (g, filename); > } With the above, this makes sense now. > Also, should we update the documentation? > > http://libguestfs.org/guestfs.3.html#guestfs_add_cdrom > > Maybe or maybe not worth it. Rgiht, worth it, updated. > > +# https://bugzilla.redhat.com/show_bug.cgi?id=563450 > > +# Test the order of added images > > + > > +set -e > > +export LANG=C > > + > > +rm -f test.out > > + > > +../../f...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...

...as no tests warning: "guestfs_test0rhashtableerr" has no tests warning: "guestfs_launch" has no tests warning: "guestfs_wait_ready" has no tests warning: "guestfs_kill_subprocess" has no tests warning: "guestfs_add_drive" has no tests warning: "guestfs_add_cdrom" has no tests warning: "guestfs_add_drive_ro" has no tests warning: "guestfs_config" has no tests warning: "guestfs_set_qemu" has no tests warning: "guestfs_set_path" has no tests warning: "guestfs_set_append" has no tests warning: "guestf...