Chen Hanxiao
2015-Mar-10 10:05 UTC
[Libguestfs] [PATCH] gui: fix a syntax-check issue of bindtextdomain
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 60f226e..f661f49 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -70,7 +70,7 @@ static GtkWidget *run_dlg, *cancel_button, *reboot_button; /* The entry point from the main program. - * Note that gtk_init etc have already been called in main(). + * Note that gtk_init etc have already been called in main. */ void gui_application (struct config *config) -- 2.1.0
Richard W.M. Jones
2015-Mar-10 19:38 UTC
Re: [Libguestfs] [PATCH] gui: fix a syntax-check issue of bindtextdomain
On Tue, Mar 10, 2015 at 06:05:43AM -0400, Chen Hanxiao wrote:> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> > --- > p2v/gui.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/p2v/gui.c b/p2v/gui.c > index 60f226e..f661f49 100644 > --- a/p2v/gui.c > +++ b/p2v/gui.c > @@ -70,7 +70,7 @@ static GtkWidget *run_dlg, > *cancel_button, *reboot_button; > > /* The entry point from the main program. > - * Note that gtk_init etc have already been called in main(). > + * Note that gtk_init etc have already been called in main. > */ > void > gui_application (struct config *config) > --Thanks for looking at the output of 'make syntax-check'. However I think a lot of that output consists of false alarms. It does need work to either remove 'make syntax-check' or to make the output better and actionable. I have added this patch to my queue since it may reduce the amount of noise in syntax-check output. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Possibly Parallel Threads
- Re: [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check
- [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check
- [PATCH v2 0/2] p2v: add Shutdown option
- [PATCH 0/2] p2v: add Shutdown option
- [PATCH 0/2] p2v: Allow virt-p2v to be built with Gtk 2 or 3.