search for: run_dlg

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Changes from v1: - fix shutdown command Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c |

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c | 119

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

...alignment (GTK_MISC (status_label), 0., 0.5); - gtk_misc_set_padding (GTK_MISC (status_label), 10, 10); + set_alignment (status_label, 0., 0.5); + set_padding (status_label, 10, 10); gtk_container_add (GTK_CONTAINER (v2v_output_sw), v2v_output); - gtk_box_pack_start (GTK_BOX (GTK_DIALOG (run_dlg)->vbox), - v2v_output_sw, TRUE, TRUE, 0); - gtk_box_pack_start (GTK_BOX (GTK_DIALOG (run_dlg)->vbox), - log_label, TRUE, TRUE, 0); - gtk_box_pack_start (GTK_BOX (GTK_DIALOG (run_dlg)->vbox), - status_label, TRUE, TRUE, 0); +...

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

...Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > p2v/gui.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/p2v/gui.c b/p2v/gui.c > index a50307d..2df5017 100644 > --- a/p2v/gui.c > +++ b/p2v/gui.c > @@ -69,7 +69,7 @@ static GtkWidget *run_dlg, > *cancel_button; > > /* The entry point from the main program. > - * Note that gtk_init etc have already been called in main(). > + * Note that gtk_init etc have already been called in main_(). > */ > void > gui_application (struct config *config) Maybe it would...

...Tao <hutao@cn.fujitsu.com> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 60f226e..f661f49 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -70,7 +70,7 @@ static GtkWidget *run_dlg, *cancel_button, *reboot_button; /* The entry point from the main program. - * Note that gtk_init etc have already been called in main(). + * Note that gtk_init etc have already been called in main. */ void gui_application (struct config *config) -- 2.1.0

...along with this program; if not, write to the Free Software\n" - "Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.\n"; diff --git a/p2v/gui.c b/p2v/gui.c index 82c2402..563e1a7 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -134,6 +134,22 @@ static GtkWidget *run_dlg, /* Colour tags used in the v2v_output GtkTextBuffer. */ static GtkTextTag *v2v_output_tags[16]; +/* The license of virt-p2v, for the About dialog. */ +static const char gplv2plus[] = + "This program is free software; you can redistribute it and/or modify\n" + "it under the ter...

..., NULL); back = gtk_dialog_get_widget_for_response (GTK_DIALOG (conv_dlg), 1); start_button = gtk_dialog_get_widget_for_response (GTK_DIALOG (conv_dlg), 2); @@ -1703,8 +1715,8 @@ create_running_dialog (void) /* Buttons. */ gtk_dialog_add_buttons (GTK_DIALOG (run_dlg), - _("Cancel conversion ..."), 1, - _("Reboot"), 2, + _("_Cancel conversion ..."), 1, + _("_Reboot"), 2, NULL); cancel_button =...

In an effort to reduce the code, start to use few bits of GLib: - replace the gnulib c-type module - replace the gnulib getprogname module - use g_spawn_sync to launch curl, and drop a file reading function Pino Toscano (6): Include glib.h in p2v.h Use g_ascii_isspace instead of c_isspace from gnulib Use g_get_prgname instead of getprogname from gnulib build: remove no more used gnulib

In the run dialog, I have implemented an ANSI colour escape sequence interpreter, so that colours displayed by the remote virt-v2v are now shown to the user. (https://bugzilla.redhat.com/show_bug.cgi?id=1314244) This requires virt-v2v to send colours. It wasn't doing that because the output was a pipe (as we capture the output into the log file). So I added a global --colours option to make

...t property, so the about dialog will show its own license text, and there is no need for our custom one. --- p2v/gui.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/p2v/gui.c b/p2v/gui.c index 563e1a7..203ca2c 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -134,6 +134,7 @@ static GtkWidget *run_dlg, /* Colour tags used in the v2v_output GtkTextBuffer. */ static GtkTextTag *v2v_output_tags[16]; +#if !GTK_CHECK_VERSION(3,0,0) /* gtk < 3 */ /* The license of virt-p2v, for the About dialog. */ static const char gplv2plus[] = "This program is free software; you can redistribute...

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index a50307d..2df5017 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -69,7 +69,7 @@ static GtkWidget *run_dlg, *cancel_button; /* The entry point from the main program. - * Note that gtk_init etc have already been called in main(). + * Note that gtk_init etc have already been called in main_(). */ void gui_application (struct config *config) -- 1.9.3

Hi, this series update libguestfs to a recent gnulib version, so that we can use its new getprogname module, and solve altogether one of the porting issues (the need for 'program_name' by the error module of gnulib), and have a single way to get the name of the current program. A number of changes in tools mostly, although mechanical. Thanks, Pino Toscano (3): Update gnulib to latest

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check